Skip to content

test: convert .then to async/await for beaconUpload test#1081

Merged
jaissica12 merged 1 commit into
test/SDKE-300-convert-all-then-to-async-await-in-testsfrom
test/SDKE-339-convert-then-to-async-await-in-beaconUpload-test
Oct 9, 2025
Merged

test: convert .then to async/await for beaconUpload test#1081
jaissica12 merged 1 commit into
test/SDKE-300-convert-all-then-to-async-await-in-testsfrom
test/SDKE-339-convert-then-to-async-await-in-beaconUpload-test

Conversation

@jaissica12

Copy link
Copy Markdown
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Updated all occurrences of .then to async/await within beaconUpload test

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@sonarqubecloud

sonarqubecloud Bot commented Oct 6, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
53.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@jaissica12 jaissica12 requested a review from rmi22186 October 7, 2025 20:26
@jaissica12 jaissica12 marked this pull request as ready for review October 7, 2025 20:26
@jaissica12 jaissica12 merged commit a515d8e into test/SDKE-300-convert-all-then-to-async-await-in-tests Oct 9, 2025
23 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants