fix: Ensure transitory DAS for launcherOptions settings#1117
Closed
rmi22186 wants to merge 3 commits into
Closed
Conversation
|
samdozor
requested changes
Nov 19, 2025
samdozor
left a comment
Contributor
There was a problem hiding this comment.
as we chatted - this mapping shouldn't exist. we can bring it back if we want but the guidance for clients should be that if they do, they need to be setting a persistent ID, otherwise we will blow up identity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Background
A DAS is required for the identity framework to succeed for anonymous users. Previously no DAS was created due to
initializeStoragereturning early under a newly introduced code path for anoFunctionalsetting forlauncherOptions. With this PR, a DAS is created for the purposes of the identity call succeeding but is never saved to persistence.What Has Changed
storeDataInMemorywith no arguments which reuses existing code to create a new DAS.Screenshots/Video
Checklist
Reference Issue (For employees only. Ignore if you are an outside contributor)