feat: map Rokt Privacy flags in cookieSyncManager by jaissica12 · Pull Request #1140 · mParticle/mparticle-web-sdk

jaissica12 · 2026-01-14T22:19:20Z

Background

Rokt cookie syncs need to respect user privacy preferences (noTargeting, noFunctional flag) passed via launcherOptions. This is a workaround to block Rokt cookie syncs without requiring advertisers to implement the full consent framework.

What Has Changed

privacyManager.ts: Stores noFunctional and noTargeting flags from launcherOptions
cookieSyncManager.ts: Blocks Rokt (moduleId 1277) cookie sync when noTargeting is true
Tests: Jest unit tests + integration tests

Screenshots/Video

{Include any screenshots or video demonstrating the new feature or fix, if applicable}

Checklist

I have performed a self-review of my own code.
I have made corresponding changes to the documentation.
I have added tests that prove my fix is effective or that my feature works.
I have tested this locally.

Additional Notes

{Any additional information or context relevant to this PR}

Reference Issue (For employees only. Ignore if you are an outside contributor)

Closes https://go/j/SDKE-837

Copilot

Pull request overview

This PR adds privacy flag support to control Rokt cookie syncing based on user consent preferences. It introduces a new PrivacyManager component that stores noFunctional and noTargeting flags from launcherOptions, and blocks Rokt (moduleId 1277) cookie syncs when noTargeting is true.

Changes:

Introduced PrivacyManager class to store and manage privacy flags from launcherOptions
Modified CookieSyncManager to check noTargeting flag and block Rokt cookie syncs when enabled
Added comprehensive unit tests (Jest) and integration tests for the privacy flag functionality

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/privacyManager.ts	New component that manages privacy flags (noFunctional, noTargeting) with validation and default values
src/mp-instance.ts	Initializes PrivacyManager and adds it to the SDK instance interface
src/cookieSyncManager.ts	Adds Rokt module ID constant and implements privacy flag check to block Rokt cookie syncs
test/jest/privacyManager.spec.ts	Unit tests for PrivacyManager covering initialization, defaults, and flag validation
test/jest/cookieSyncManager.spec.ts	Unit tests verifying Rokt cookie sync blocking behavior based on noTargeting flag
test/jest/roktManager.spec.ts	Test verifying privacy flags are passed through to RoktManager's launcherOptions
test/src/tests-cookie-syncing.ts	Comprehensive integration tests covering edge cases like MPID changes, consent interaction, and multi-partner scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…lean up tests

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rmi22186 · 2026-01-16T02:20:16Z

Just reviewed. I feel like having a full privacyManager is over-engineering for the scope of the problem. Lots of set up to just get a formal getter. (90 lines in the class for this).

There aren't other use cases for it right now, and if there is a future where we do more with privacy flags maybe this is the right approach, but I also think there would be a larger refactor incorporting the consent framework.

Seems like we could simply work with the existing Store.SDKConfig, and do something like:

if (moduleId === PARTNER_MODULE_IDS.Rokt && mpInstance._Store.SDKConfig.launcherOptions?.noTargeting === true) {    return;}

…kieConsent, update tests

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sonarqubecloud · 2026-01-16T19:35:05Z

Quality Gate failed

Failed conditions
8.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

# [2.53.0](v2.52.0...v2.53.0) (2026-01-20) ### Features * map Rokt Privacy flags in cookieSyncManager ([#1140](#1140)) ([3840afa](3840afa)) * Migrate Logger to Typescript ([#1120](#1120)) ([#1141](#1141)) ([e8d1ef1](e8d1ef1))

mparticle-automation · 2026-01-20T14:26:26Z

🎉 This PR is included in version 2.53.0 🎉

The release is available on:

v2.53.0
GitHub release

Your semantic-release bot 📦🚀

feat: map Rokt Privacy flags in cookieSyncManager

c6751c0

jaissica12 requested review from alexs-mparticle and rmi22186 January 14, 2026 22:19

alexs-mparticle requested a review from Copilot January 15, 2026 15:21

Copilot started reviewing on behalf of alexs-mparticle January 15, 2026 15:22 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

Comment thread test/jest/roktManager.spec.ts

Comment thread src/cookieSyncManager.ts Outdated

Comment thread test/src/tests-cookie-syncing.ts Outdated

Comment thread test/src/tests-cookie-syncing.ts Outdated

alexs-mparticle requested changes Jan 15, 2026

View reviewed changes

Comment thread src/cookieSyncManager.ts Outdated

Comment thread src/privacyManager.ts Outdated

Comment thread src/mp-instance.ts Outdated

Comment thread test/jest/cookieSyncManager.spec.ts Outdated

Comment thread test/jest/roktManager.spec.ts Outdated

add constructor in cookieSyncManager, links docs in privacyManager, c…

c4f021a

…lean up tests

jaissica12 requested a review from Copilot January 15, 2026 17:19

Copilot started reviewing on behalf of jaissica12 January 15, 2026 17:20 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

Comment thread src/privacyManager.ts Outdated

Comment thread src/cookieSyncManager.ts Outdated

add . to PrivacyManager description

7e8885b

jaissica12 requested a review from Copilot January 15, 2026 17:46

Copilot started reviewing on behalf of jaissica12 January 15, 2026 17:46 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

jaissica12 requested a review from alexs-mparticle January 15, 2026 17:56

alexs-mparticle reviewed Jan 15, 2026

View reviewed changes

Comment thread src/privacyManager.ts Outdated

added error logging for invalid privacy flags

ceeb09b

jaissica12 requested a review from alexs-mparticle January 15, 2026 20:20

alexs-mparticle approved these changes Jan 15, 2026

View reviewed changes

rmi22186 reviewed Jan 16, 2026

View reviewed changes

Comment thread src/cookieConsentManager.ts Outdated

rmi22186 reviewed Jan 16, 2026

View reviewed changes

Comment thread src/privacyManager.ts Outdated

rmi22186 reviewed Jan 16, 2026

View reviewed changes

Comment thread src/privacyManager.ts Outdated

rename privacyManager to cokkieConsentManager, remove logger from coo…

9e4d51c

…kieConsent, update tests

jaissica12 requested a review from Copilot January 16, 2026 17:09

Copilot started reviewing on behalf of jaissica12 January 16, 2026 17:09 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Comment thread src/utils.ts Outdated

Comment thread test/jest/roktManager.spec.ts

jaissica12 added 2 commits January 16, 2026 12:13

remove conditional if block from CookieConsentManager

b6cfb71

remove unused isBoolean export from utils

256166f

jaissica12 requested a review from Copilot January 16, 2026 17:19

Copilot started reviewing on behalf of jaissica12 January 16, 2026 17:19 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

jaissica12 requested review from alexs-mparticle and rmi22186 January 16, 2026 17:24

alexs-mparticle requested changes Jan 16, 2026

View reviewed changes

Comment thread src/cookieConsentManager.ts Outdated

clean up CookieConsentManager constructor and update tests

e262374

jaissica12 requested a review from alexs-mparticle January 16, 2026 19:38

alexs-mparticle approved these changes Jan 16, 2026

View reviewed changes

rmi22186 reviewed Jan 16, 2026

View reviewed changes

Comment thread src/cookieConsentManager.ts

rmi22186 approved these changes Jan 16, 2026

View reviewed changes

jaissica12 merged commit 3840afa into development Jan 20, 2026
27 of 32 checks passed

mparticle-automation added the released label Jan 20, 2026

Uh oh!

Conversation

jaissica12 commented Jan 14, 2026

Background

What Has Changed

Screenshots/Video

Checklist

Additional Notes

Reference Issue (For employees only. Ignore if you are an outside contributor)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

rmi22186 commented Jan 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jan 16, 2026

Quality Gate failed

Uh oh!

Uh oh!

Uh oh!

mparticle-automation commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants