Skip to content

feat: add devPassedAttributes to selectPlacements#1142

Closed
jaissica12 wants to merge 1 commit into
developmentfrom
SDKE-786-log-custom-event-for-selectPlacements
Closed

feat: add devPassedAttributes to selectPlacements#1142
jaissica12 wants to merge 1 commit into
developmentfrom
SDKE-786-log-custom-event-for-selectPlacements

Conversation

@jaissica12

Copy link
Copy Markdown
Contributor

Background

  • Add devPassedAttributes along with the enrichedAttributes for better debugging of selectPlacements

What Has Changed

  • Added devPassedAttributes in selectPlacements
  • Updated roktManager.spec.ts test

Screenshots/Video

  • {Include any screenshots or video demonstrating the new feature or fix, if applicable}

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • {Any additional information or context relevant to this PR}

Reference Issue (For employees only. Ignore if you are an outside contributor)

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
34.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a devPassedAttributes field to the selectPlacements options object to improve debugging capabilities. The field contains the original unmapped attributes passed by developers, while the attributes field contains the processed/mapped attributes used by the Rokt SDK.

Changes:

  • Added devPassedAttributes to the enriched options in selectPlacements method to capture original unmapped attributes for debugging
  • Updated all existing tests to expect devPassedAttributes in the kit method calls
  • Added two new tests specifically for verifying devPassedAttributes behavior

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/roktManager.ts Added devPassedAttributes: attributes to enrichedOptions object to pass original unmapped attributes for debugging
test/jest/roktManager.spec.ts Updated all selectPlacements test expectations to include devPassedAttributes and added two new tests to verify the feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jaissica12 jaissica12 closed this Jan 16, 2026
@jaissica12 jaissica12 deleted the SDKE-786-log-custom-event-for-selectPlacements branch January 16, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants