feat: add devPassedAttributes to selectPlacements#1142
Closed
jaissica12 wants to merge 1 commit into
Closed
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR adds a devPassedAttributes field to the selectPlacements options object to improve debugging capabilities. The field contains the original unmapped attributes passed by developers, while the attributes field contains the processed/mapped attributes used by the Rokt SDK.
Changes:
- Added
devPassedAttributesto the enriched options inselectPlacementsmethod to capture original unmapped attributes for debugging - Updated all existing tests to expect
devPassedAttributesin the kit method calls - Added two new tests specifically for verifying
devPassedAttributesbehavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/roktManager.ts | Added devPassedAttributes: attributes to enrichedOptions object to pass original unmapped attributes for debugging |
| test/jest/roktManager.spec.ts | Updated all selectPlacements test expectations to include devPassedAttributes and added two new tests to verify the feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Background
devPassedAttributesalong with theenrichedAttributesfor better debugging ofselectPlacementsWhat Has Changed
devPassedAttributesinselectPlacementsScreenshots/Video
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)