feat: remove batch forwarding to kits#1281
Conversation
Remove the client-side sendBatchToForwarders path that pushed event batches into kit processBatch. Server-side mParticle integration now handles this data, making the client-side batch-stream forwarding redundant. - Drop the sendBatchToForwarders() call site in batchUploader.ts - Remove the sendBatchToForwarders method and its now-unused batch filtering helper imports from forwarders.js - Remove the associated test coverage in batchUploader.spec.ts and tests-forwarders.ts
PR SummaryMedium Risk Overview
Tests for batch forwarding in Reviewed by Cursor Bugbot for commit cc85fa1. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
1 participant
Summary
Removes the client-side
sendBatchToForwardersbatch-forwarding path that pushed event batches into kitprocessBatch. Server-side mParticle integration now handles this data, making the client-side batch-stream forwarding redundant.This is the SDK-side slice of a broader effort to remove the redundant client-side mParticle → Rokt batch-stream pipeline (the kit and WSDK changes are tracked separately).
Changes
src/batchUploader.ts— drop thesendBatchToForwarders()call site increateNewBatches.src/forwarders.js— remove thesendBatchToForwardersmethod and its now-unused batch-filtering helper imports (isBatchEventAllowed,filterBatchEventAttributes,filterBatchIdentities).test/jest/batchUploader.spec.ts— remove thebatch forwarding to kitsdescribe block and its mock.test/src/tests-forwarders.ts— remove thebatch forwardingdescribe block.Notes
src/forwarder-utils.ts(added in feat: enable data filtering for batches #1245) are now only referenced by removed code. They are left in place for this PR to keep the diff scoped; they can be cleaned up in a follow-up.sendBatchToForwardersalready no-op'd for kits withoutprocessBatch, so this has no hard ordering dependency on the kit/WSDK changes.Testing
npm run lint— clean.npm run test:jest— no new failures introduced (pre-existing failures insdkToEventsApiConverter.tsTS error and an untracked localclick-id-refactor/dir are unrelated to this change).