Skip to content

chore: remove ROKT_KIT_ATTACHED info log#1288

Open
mattbodle wants to merge 1 commit into
mParticle:developmentfrom
mattbodle:chore/remove-rokt-kit-attached-log
Open

chore: remove ROKT_KIT_ATTACHED info log#1288
mattbodle wants to merge 1 commit into
mParticle:developmentfrom
mattbodle:chore/remove-rokt-kit-attached-log

Conversation

@mattbodle

Copy link
Copy Markdown
Contributor

Summary

  • Remove the informational log emitted from RoktManager.attachKit() ("RoktManager: Kit attached, Rokt is ready") when the Rokt kit connects.
  • Remove the now-unused ROKT_KIT_ATTACHED entry from the ErrorCodes map in src/reporting/types.ts.

Test plan

  • eslint src/ — no issues
  • tsc -p . --noEmit — no errors
  • Jest suites roktManager, reportingLogger, logging-integration — 130 passed, 0 failed
  • CI green

Remove the informational log emitted from RoktManager.attachKit() when the
Rokt kit connects, along with the now-unused ROKT_KIT_ATTACHED error code.
@mattbodle mattbodle requested a review from a team as a code owner July 15, 2026 20:55
@cursor

cursor Bot commented Jul 15, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Observability-only cleanup with no changes to Rokt initialization, queuing, or ready callbacks.

Overview
Removes the informational reporting log that fired when the Rokt web kit connects in RoktManager.attachKit() ("RoktManager: Kit attached, Rokt is ready"). Kit attach behavior is unchanged: account/integration metadata is still stored, the message queue is still drained, and onReadyCallback still runs.

Deletes the unused ROKT_KIT_ATTACHED value from the shared ErrorCodes map in src/reporting/types.ts so reporting codes stay aligned with what the SDK actually emits.

Reviewed by Cursor Bugbot for commit c80c2e8. Bugbot is set up for automated code reviews on this repo. Configure here.

@sonarqubecloud

Copy link
Copy Markdown

@rmi22186 rmi22186 changed the base branch from master to development July 15, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants