Fix android test failures

Remove the tests that are testing null values where the param can't be null from JS

Author: thomson-t

android/src/main/java/com/mparticle/react/MParticleModule.kt

@@ -112,7 +112,7 @@ class MParticleModule(private val reactContext: ReactApplicationContext) :
         value?.let {
             val list = mutableListOf<String>()
             for (i in 0 until it.size()) {
-                list.add(it.getString(i))
+                it.getString(i)?.let { element -> list.add(element) }
             }
 
             val selectedUser = MParticle.getInstance()?.Identity()?.getUser(parseMpid(mpid))

android/src/test/java/com/mparticle/react/MParticleUserTest.java

@@ -28,6 +28,7 @@
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.doReturn;
 
 @RunWith(MockitoJUnitRunner.class)
 public class MParticleUserTest {
@@ -40,25 +41,10 @@ public void before() {
         MParticle.setInstance(Mockito.mock(MParticle.class));
         Mockito.when(MParticle.getInstance().Identity()).thenReturn(Mockito.mock(IdentityApi.class));
         Mockito.lenient().when(MParticle.getInstance().Identity().getUser(0L)).thenReturn(null);
-        mParticleUser = new MParticleModule(Mockito.mock(ReactApplicationContext.class)) {
-            @Override
-            public WritableMap getWritableMap() {
-                return new MockMap();
-            }
-        };
-    }
 
-    @Test
-    public void tesNullMParticleUserSetters() {
-        Exception exception = null;
-        try {
-            mParticleUser.setUserAttribute(null, "key", "values");
-            mParticleUser.setUserTag(null, "test");
-            mParticleUser.setUserAttributeArray(null, "keuy", new MockReadableArray());
-        } catch (Exception e) {
-            exception = e;
-        }
-        assertNull(exception);
+        MParticleModule realModule = new MParticleModule(Mockito.mock(ReactApplicationContext.class));
+        mParticleUser = Mockito.spy(realModule);
+        doReturn(new MockMap()).when(mParticleUser).getWritableMap();
     }
 
     @Test
@@ -116,21 +102,6 @@ public void invoke(Object... args) {
         }
     }
 
-    @Test
-    public void testGetUserIdentitiesNullUser() {
-        final Mutable<Boolean> callbackInvoked = new Mutable<>(false);
-
-        mParticleUser.getUserIdentities(null, new Callback() {
-            @Override
-            public void invoke(Object... args) {
-                assertEquals(0, args.length);
-                callbackInvoked.value = true;
-            }
-        });
-
-        assertTrue(callbackInvoked.value);
-    }
-
     @Test
     public void testSetUserTag() {
         final Mutable<String> tag = new Mutable<>();
@@ -177,21 +148,6 @@ public void invoke(Object... args) {
         assertTrue(callbackInvoked.value);
     }
 
-    @Test
-    public void getFirstSeenTimeNullUser() {
-        final Mutable<Boolean> callbackInvoked = new Mutable<>(false);
-
-        mParticleUser.getFirstSeen(null, new Callback() {
-            @Override
-            public void invoke(Object... args) {
-                assertEquals(0, args.length);
-                callbackInvoked.value = true;
-            }
-        });
-
-        assertTrue(callbackInvoked.value);
-    }
-
     @Test
     public void getLastSeenTime() {
         final Mutable<Boolean> callbackInvoked = new Mutable<>(false);
@@ -215,19 +171,4 @@ public void invoke(Object... args) {
 
         assertTrue(callbackInvoked.value);
     }
-
-    @Test
-    public void getLastSeenTimeNullUser() {
-        final Mutable<Boolean> callbackInvoked = new Mutable<>(false);
-
-        mParticleUser.getLastSeen(null , new Callback() {
-            @Override
-            public void invoke(Object... args) {
-                assertEquals(0, args.length);
-                callbackInvoked.value = true;
-            }
-        });
-
-        assertTrue(callbackInvoked.value);
-    }
 }