Migrate to Jupyter Lab v4 by gjmooney · Pull Request #135 · maartenbreddels/ipywebrtc

gjmooney · 2024-01-18T15:58:46Z

No description provided.

martinRenou · 2024-01-18T16:04:12Z

Given that you are switching from npm to yarn we may want to use yarn in the package.json scripts

maartenbreddels

Hi,

thank you for the work!
I would prefer however if all unrelated changes are not pushed to this branch.
For ipyreact we added styling like this: widgetti/ipyreact#51
using ruff + prettier but that should not go into this PR.
Also, does a build with jupyterlab4 make ipywebrtc still work in jupyterlab3.x?
I'm happy to have formatting/style fixes btw, but not mixed with other PR's :)
Hope I don't discouraged you too much, feel free to push back.

Cheers,

Maarten

maartenbreddels · 2024-01-19T10:56:04Z

+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Install Conda environment with Micromamba
+        uses: mamba-org/setup-micromamba@v1
+        with:
+          environment-file: dev_environment.yml
+          condarc: |
+            dependencies:
+              - python==${{ matrix.python-version }}
+
+      - name: Test flake8
+        run: flake8 ipywebrtc --ignore=E501,F405
+
+      - name: Install ipywebrtc
+        run: pip install .
+
+      - name: Check installation files
+        run: |
+          test -d $CONDA_PREFIX/share/jupyter/nbextensions/jupyter-webrtc
+          test -f $CONDA_PREFIX/share/jupyter/nbextensions/jupyter-webrtc/extension.js
+          test -f $CONDA_PREFIX/share/jupyter/nbextensions/jupyter-webrtc/index.js
+          test -d $CONDA_PREFIX/share/jupyter/labextensions/jupyter-webrtc
+          test -f $CONDA_PREFIX/share/jupyter/labextensions/jupyter-webrtc/package.json
+
+      - name: Check nbextension and labextension
+        run: |
+          jupyter labextension list 2>&1 | grep -ie "jupyter-webrtc.*enabled.*ok" -
+
+      - name: Run js tests
+        run: |
+          npm install
+          npm run test
+        working-directory: js
+
+      - name: Build docs (Only on MacOS for build speed)
+        if: matrix.os == 'macos-latest'
+        run: |
+          cd docs/source/
+          sphinx-build . _build/html
+          cd ../..


Please avoid unneeded changes/reformatting, or put them in a separate PR or top commit first. This makes tracking changes much easier.

I understand what you're saying, I can do a new PR for style changes.

maartenbreddels · 2024-01-19T10:56:46Z

+      - name: Checkout
+        uses: actions/checkout@v2

-    - name: Checkout
-      uses: actions/checkout@v2
-
-    - name: Install Conda environment with Micromamba
-      uses: mamba-org/provision-with-micromamba@main
-      with:
-        environment-name: ipywebrtc-dev
-        environment-file: dev_environment.yml
-        python-version: ${{ matrix.python-version }}
-        mamba-version: "*"
-        auto-activate-base: false
-        channels: conda-forge
-
-    - name: Build packages
-      run: |
-        python setup.py sdist bdist_wheel
-        cd dist
-        sha256sum * | tee SHA256SUMS
-    - name: Upload builds
-      uses: actions/upload-artifact@v2
-      with:
-        name: dist ${{ github.run_number }}
-        path: ./dist
+      - name: Install Conda environment with Micromamba
+        uses: mamba-org/setup-micromamba@v1
+        with:
+          environment-file: dev_environment.yml
+          condarc: |
+            dependencies:
+              - python==${{ matrix.python-version }}
+
+      - name: Build packages
+        run: |
+          python setup.py sdist bdist_wheel
+          cd dist
+          sha256sum * | tee SHA256SUMS
+      - name: Upload builds
+        uses: actions/upload-artifact@v2
+        with:
+          name: dist ${{ github.run_number }}
+          path: ./dist


Same here, very difficult to see what actually changed and what is related to the intention or the PR

It's easier to review hiding the whitespaces changes https://github.com/maartenbreddels/ipywebrtc/pull/135/files?diff=split&w=1

w=1 is the query parameter

maartenbreddels · 2024-01-19T10:57:18Z

+          - python: "3.6"
+            dist: "ipywebrtc*.tar.gz"
+          - python: "3.9"
+            dist: "ipywebrtc*.whl"


This isn't that bad, because it's not mixed with other changes, but adds noise.

maartenbreddels · 2024-01-19T10:58:20Z

+import * as services from "@jupyterlab/services";
+import * as Backbone from "backbone";
+import * as widgets from "@jupyter-widgets/controls";
+import * as base from "@jupyter-widgets/base";
+import * as sinon from "sinon";


Also the changes in this file are not needed, although I welcome a style fix :)

flokli · 2025-04-30T09:22:17Z

@maartenbreddels

Also, does a build with jupyterlab4 make ipywebrtc still work in jupyterlab3.x?

https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#jupyterlab-3-x-to-4-x says the following:

Because of significant type changes from JupyterLab 3.x to 4.x, we recommend publishing a new major version of your extension to work with each major version of JupyterLab. For examples of extensions that use different major versions for Lab 3 and Lab 4, see jupyterlab-vim and jupyter-ai.

I've been running into some incompatibility issues and Javascript errors when packaging this for nixpkgs, which uses Jupyter Lab v4. I'd be happy to take up the changes from this PR, split up the formatting changes into separate commits, but I'd probably suggest to switch to v4. People stuck with v3 can still pin a old release.

flokli · 2025-06-17T14:31:15Z

Poke :-) @maartenbreddels, how do you want to proceed with this?

gjmooney added 3 commits January 16, 2024 14:04

Migrate to Jupyter lab v4

919975f

Change JupyterLab version in pyproject.toml

2ec7c56

Add ts-ignore to test

2b644aa

martinRenou reviewed Jan 18, 2024

View reviewed changes

gjmooney added 5 commits January 19, 2024 08:47

Change npm to yarn in package.json scripts

524b819

Update micromamba setup in workflow

512bb08

Add yarn command to setup.py

5bac400

Remove notebook 6 commands from CI

ca53993

Pin versions for testing

78f8b1b

maartenbreddels requested changes Jan 19, 2024

View reviewed changes

flokli mentioned this pull request Apr 30, 2025

python312Packages.ipywebrtc: init at 0.6.0 NixOS/nixpkgs#402858

Closed

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to Jupyter Lab v4#135

Migrate to Jupyter Lab v4#135
gjmooney wants to merge 8 commits into
maartenbreddels:masterfrom
gjmooney:v4_migrate

gjmooney commented Jan 18, 2024

Uh oh!

martinRenou Jan 18, 2024

Uh oh!

maartenbreddels left a comment

Uh oh!

maartenbreddels Jan 19, 2024

Uh oh!

gjmooney Jan 19, 2024

Uh oh!

maartenbreddels Jan 19, 2024

Uh oh!

martinRenou Jan 19, 2024

Uh oh!

martinRenou Jan 19, 2024

Uh oh!

maartenbreddels Jan 19, 2024

Uh oh!

maartenbreddels Jan 19, 2024

Uh oh!

flokli commented Apr 30, 2025

Uh oh!

flokli commented Jun 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gjmooney commented Jan 18, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maartenbreddels left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flokli commented Apr 30, 2025

Uh oh!

flokli commented Jun 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants