Skip to content

Commit 13a13e3

Browse files
committed
fix typos, handle error state
1 parent 6e38cab commit 13a13e3

3 files changed

Lines changed: 9 additions & 5 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ Supports **linux/amd64**, **darwin/amd64**, and **darwin/arm64**.
4747

4848
| env vars | Required | Default | Description |
4949
|---|---|---|---|
50-
| `VERION` | false | latest | download a specific version |
50+
| `VERSION` | false | latest | download a specific version |
5151
| `ALIAS` | false | reposcan | specify binary name |
5252

5353
```sh

internal/telemetry/telemetry.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,9 @@ func Send(
6262
fmt.Fprintln(stdout, "More info: https://github.com/mabd-dev/reposcan#telemetry")
6363

6464
telemetry.Warned = true
65-
writeTelemetry(filePath, telemetry)
65+
if err := writeTelemetry(filePath, telemetry); err != nil {
66+
logger.Error("Failed to persist telemetry warned state, error=%v", err.Error())
67+
}
6668
}
6769

6870
sendTelemetry(token, debug, filter, outputFormat, repoCount, isCI)
@@ -90,7 +92,7 @@ func sendTelemetry(
9092
})
9193

9294
if err != nil {
93-
logger.Error("Failed to send analytics, error")
95+
logger.Error("Failed to send analytics, error=%v", err.Error())
9496
}
9597
}
9698

@@ -113,7 +115,9 @@ func getOrCreateTelemetry(filePath string) (Telemetry, error) {
113115
UUID: uuid.New().String(),
114116
Warned: false,
115117
}
116-
writeTelemetry(filePath, telemetry)
118+
if err := writeTelemetry(filePath, telemetry); err != nil {
119+
logger.Error("Failed to write new telemetry file, error=%v", err.Error())
120+
}
117121
return telemetry, nil
118122
}
119123

internal/telemetry/telemetry_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ func TestGetTelemetryFilePath_ConfigDirError_ReturnsError(t *testing.T) {
325325

326326
// ---- Send ----
327327

328-
func TestSend_CIEnvironment_PrintsMsgAndSkipsAnalytics(t *testing.T) {
328+
func TestSend_CIEnvironment_SendsAnalytics(t *testing.T) {
329329
t.Setenv("CI", "true")
330330
mock := &mockAnalytics{}
331331
setAnalytics(t, mock)

0 commit comments

Comments
 (0)