refactor(vcs): rename RepoPath to RepoInfo

Author: frittlechasm

internal/scan/scan.go

@@ -18,7 +18,7 @@ import (
 func FindRepos(
 	roots []string,
 	dirignore []string,
-) (repoPaths []vcs.RepoPath, warnings []string) {
+) (repos []vcs.RepoInfo, warnings []string) {
 	matcher := NewIgnoreMatcher(roots, dirignore)
 
 	visitedDir := map[string]struct{}{}
@@ -47,7 +47,7 @@ func FindRepos(
 			visitedDir[path] = struct{}{}
 
 			if repoType, ok := detectRepoType(path); ok {
-				repoPaths = append(repoPaths, vcs.RepoPath{
+				repos = append(repos, vcs.RepoInfo{
 					Path: path,
 					Type: repoType,
 				})
@@ -57,7 +57,7 @@ func FindRepos(
 		})
 	}
 
-	return removeDuplicateRepoPaths(repoPaths), warnings
+	return removeDuplicateRepoInfo(repos), warnings
 }
 
 func detectRepoType(path string) (vcs.Type, bool) {
@@ -100,14 +100,14 @@ func isJJRepo(path string) bool {
 	return info.IsDir()
 }
 
-func removeDuplicateRepoPaths(repoPaths []vcs.RepoPath) []vcs.RepoPath {
-	seen := make(map[string]struct{}, len(repoPaths))
-	distinct := make([]vcs.RepoPath, 0, len(repoPaths))
+func removeDuplicateRepoInfo(repos []vcs.RepoInfo) []vcs.RepoInfo {
+	seen := make(map[string]struct{}, len(repos))
+	distinct := make([]vcs.RepoInfo, 0, len(repos))
 
-	for _, repoPath := range repoPaths {
-		if _, ok := seen[repoPath.Path]; !ok {
-			seen[repoPath.Path] = struct{}{}
-			distinct = append(distinct, repoPath)
+	for _, repo := range repos {
+		if _, ok := seen[repo.Path]; !ok {
+			seen[repo.Path] = struct{}{}
+			distinct = append(distinct, repo)
 		}
 	}
 

internal/scan/scan_test.go

@@ -23,7 +23,7 @@ func writeFile(t *testing.T, path string, contents string) {
 	}
 }
 
-func repoTypeByPath(repos []vcs.RepoPath) map[string]vcs.Type {
+func repoTypeByPath(repos []vcs.RepoInfo) map[string]vcs.Type {
 	result := map[string]vcs.Type{}
 	for _, repo := range repos {
 		result[repo.Path] = repo.Type

internal/vcs/concurrent.go

@@ -15,7 +15,7 @@ type repoResult struct {
 }
 
 func GetRepoStatesConcurrent(
-	repos []RepoPath,
+	repos []RepoInfo,
 	registry *Registry,
 	maxWorkers int,
 ) ([]report.RepoState, []string) {
@@ -26,7 +26,7 @@ func GetRepoStatesConcurrent(
 	states := []report.RepoState{}
 	warnings := []string{}
 
-	jobs := make(chan RepoPath, maxWorkers*2)
+	jobs := make(chan RepoInfo, maxWorkers*2)
 	results := make(chan repoResult, maxWorkers*2)
 
 	var wg sync.WaitGroup

internal/vcs/concurrent_test.go

@@ -28,7 +28,7 @@ func (p stubProvider) CheckRepoState(path string) (report.RepoState, []string) {
 }
 
 func TestGetRepoStatesConcurrent_SortsResultsAndPreservesWarnings(t *testing.T) {
-	repos := []RepoPath{
+	repos := []RepoInfo{
 		{Path: "/tmp/z-jj", Type: TypeJJ},
 		{Path: "/tmp/a-git", Type: TypeGit},
 		{Path: "/tmp/m-jj", Type: TypeJJ},
@@ -78,7 +78,7 @@ func TestGetRepoStatesConcurrent_SortsResultsAndPreservesWarnings(t *testing.T)
 }
 
 func TestGetRepoStatesConcurrent_WarnsWhenProviderIsMissing(t *testing.T) {
-	repos := []RepoPath{{Path: "/tmp/repo", Type: TypeJJ}}
+	repos := []RepoInfo{{Path: "/tmp/repo", Type: TypeJJ}}
 
 	states, warnings := GetRepoStatesConcurrent(repos, NewRegistry(), 1)
 

internal/vcs/types.go

@@ -7,7 +7,7 @@ const (
 	TypeJJ  Type = "jj"
 )
 
-type RepoPath struct {
+type RepoInfo struct {
 	Path string
 	Type Type
 }