feat(vcs/jj): incoming commits, VCS column, and VCS-agnostic TUI actions placeholders#38
Merged
Merged
Conversation
Add a VCS action provider interface and resolve repo actions through the provider registry. Move TUI action handling to VCS-agnostic helpers, keep Git-specific actions in the Git provider, and add jj command wrappers for future action support.
2b02e17 to
f1d7092
Compare
mabd-dev
requested changes
May 18, 2026
Owner
|
@frittlechasm I have removed |
Owner
|
@frittlechasm nevermind, i fixed them. Thank you for the great contributions |
Contributor
Author
|
Hey, thanks .. i see that we have moved the noted on the README.md and docs/cli-flags.md |
Owner
|
good point. I moved them and pushed, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Follow-up to #31 — continues jj support from #15 with deeper integration and architectural improvements.
Changes Made
--filter unpulledand--filter dirtyfilters for jjVCScolumn so users can distinguish git and jj repos at a glancegitFetch/gitPull/gitPushhandlers with avcs.ActionProviderinterface dispatched through the registry — git implements all three actions; jj intentionally returns "not implemented" for push/pull until semantics are definedcommands.gowith exported functions and structuredcommandErrorfor better error messageserrors.New("")return that produced an empty error message on quitTesting
go test ./...passes (includes new jj integration tests — requiresjjandgitbinaries)go run . -o tableshows VCS column withgit/jjvaluesgo run . -o jsonoutput includesvcsTypeandremoteStatuswith per-remote entriesgo run . --filter unpulledcorrectly includes jj and git repos with incoming commitsgo run . --filter allcorrectly includes all jj and git repos with incoming commitsCloses #15
Screenshots (if applicable)
Checklist
Additional Notes
msgVCSFunctions.gohas them commented out) until both git and jj implementations are ready. This ensures feature parity across VCS types rather than partially enabling them.