Skip to content

CHANGELOG.md added, latest change first#26

Merged
mabd-dev merged 4 commits into
mabd-dev:devfrom
vgauraha62:main
Apr 19, 2026
Merged

CHANGELOG.md added, latest change first#26
mabd-dev merged 4 commits into
mabd-dev:devfrom
vgauraha62:main

Conversation

@vgauraha62
Copy link
Copy Markdown
Contributor

changed body_path for logic

@mabd-dev mabd-dev added this to the V 1.3.8 - Send Telemetry milestone Apr 19, 2026
@mabd-dev mabd-dev linked an issue Apr 19, 2026 that may be closed by this pull request
5 tasks
@mabd-dev mabd-dev removed this from the V 1.3.8 - Send Telemetry milestone Apr 19, 2026
Copy link
Copy Markdown
Owner

@mabd-dev mabd-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your time and contribution. I will this PR once you fixed those 2 small comments


- name: Extract changelog section
run: |
VERSION="${{ github.ref_name }}"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref_name would be something like v1.3.8 but in CHANGELOG.md version entry don't have v prefix.
They look like this ## [1.3.7] - 2025-11-06

So either add v to changelog version entry or strip v from VERSION

Comment thread .github/workflows/release.yml Outdated
awk -v ver="$VERSION" '
/^## \[/ {
if (p) exit
if ($0 ~ "\\[" ver "\\]") p=1
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version entry header (## [1.3.7] - 2025-11-06) will be also included, I prefer not to have it since it's redundant

you can use next keyword to skip version entry header after settings p=1

@vgauraha62
Copy link
Copy Markdown
Contributor Author

hey @mabd-dev changes are made

Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
awk -v ver="$VERSION" '
/^## \[/ {
if (p) exit
if ($0 ~ "\\[" ver "\\]") p=1 next
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe you missed a semicolon. should be p=1; next

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the resource!!

@vgauraha62 vgauraha62 requested a review from mabd-dev April 19, 2026 13:21
@mabd-dev mabd-dev merged commit 88344fd into mabd-dev:dev Apr 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create CHANGELOG

2 participants