remove print func here due to UnicodeEncodeError#356
Open
bqwu wants to merge 1 commit into
Open
Conversation
Author
|
Hope the author can release a new version for use later. Thanks so much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I am using the trained NER model as service via http port, I found if the input json is something like
query_json = {
"id": 100,
"texts": ["Beijing"]
},
everything is right. However, if the input json is something like
query_json = {
"id": 100,
"texts": ["北京"]
},
then it raises Exception as below:
UnicodeEncodeError: 'ascii' codec can't encode characters in position 23-25: ordinal not in range(128)
I found this error comes from this print func and I think it should be removed here. In hanxiao's Bert-as-service, it does not contain this line (https://github.com/hanxiao/bert-as-service/blob/91bff1c2d0403e1afa9ee1af9dd9cb0dd58fe0d3/server/bert_serving/server/http.py#L57) and it supports Chinese well.
So I suggest removing this print func here.