Skip to content

Fix columns reading for queries with double INNER JOIN #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macbre merged 1 commit into from
Aug 25, 2025
Merged

Fix columns reading for queries with double INNER JOIN #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sql_metadata/keywords_lists.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
"INTO": "insert",
"SET": "update",
"GROUPBY": "group_by",
"INNERJOIN": "inner_join",
}


Expand Down
13 changes: 13 additions & 0 deletions test/test_getting_columns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,3 +528,16 @@ def test_nested_queries():
parser = Parser(query)
assert parser.columns == ["dt"]
assert parser.columns_dict == {"select": ["dt"]}


def test_double_inner_join():
query = """
SELECT loan.loan_id, district.a3 AS district, district.a11 AS average_salary
FROM loan
INNER JOIN account ON loan.account_id = account.account_id
INNER JOIN district ON account.district_id = district.district_id WHERE loan.duration = 60
"""

parser = Parser(query)
assert "loan.account_id" in parser.columns
assert parser.tables == ["loan", "account"]