Update CI configuration and streamline terminal input handling#410
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
=======================================
Coverage 63.76% 63.76%
=======================================
Files 352 352
Lines 68892 68892
=======================================
Hits 43929 43929
Misses 20345 20345
Partials 4618 4618 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the CI configuration to use newer macOS runners and refactors the way terminal control is handled for child processes in the Unix engine. The main focus is improving platform compatibility and streamlining terminal management during command execution.
Platform compatibility:
macos-26andmacos-26-intelrunners instead of the deprecatedmacos-15andmacos-15-intelrunners in.github/workflows/ci-main.yml. This ensures our builds and tests run on the latest available macOS environments.Terminal control handling:
syscall.SYS_IOCTLwithsyscall.TIOCSPGRP) earlier in theexec0function injsh/engine/engine_unix.go. This change ensures the child process receives terminal control before signal forwarding and other setup, improving correctness and reliability when running interactive commands. [1] [2]