Skip to content

Update CI configuration and streamline terminal input handling#410

Merged
OutOfBedlam merged 3 commits into
mainfrom
dev-darwin-env
May 21, 2026
Merged

Update CI configuration and streamline terminal input handling#410
OutOfBedlam merged 3 commits into
mainfrom
dev-darwin-env

Conversation

@OutOfBedlam
Copy link
Copy Markdown
Contributor

This pull request updates the CI configuration to use newer macOS runners and refactors the way terminal control is handled for child processes in the Unix engine. The main focus is improving platform compatibility and streamlining terminal management during command execution.

Platform compatibility:

  • Updated the CI workflow to use macos-26 and macos-26-intel runners instead of the deprecated macos-15 and macos-15-intel runners in .github/workflows/ci-main.yml. This ensures our builds and tests run on the latest available macOS environments.

Terminal control handling:

  • Moved the logic for setting the child process as the foreground process group (using syscall.SYS_IOCTL with syscall.TIOCSPGRP) earlier in the exec0 function in jsh/engine/engine_unix.go. This change ensures the child process receives terminal control before signal forwarding and other setup, improving correctness and reliability when running interactive commands. [1] [2]

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.76%. Comparing base (8dc8edc) to head (d01e4e5).

Files with missing lines Patch % Lines
jsh/engine/engine_unix.go 0.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #410   +/-   ##
=======================================
  Coverage   63.76%   63.76%           
=======================================
  Files         352      352           
  Lines       68892    68892           
=======================================
  Hits        43929    43929           
  Misses      20345    20345           
  Partials     4618     4618           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OutOfBedlam OutOfBedlam merged commit 6e4a071 into main May 21, 2026
19 of 21 checks passed
@OutOfBedlam OutOfBedlam deleted the dev-darwin-env branch May 21, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant