Feature: --xhyve-experimental-attach-image allows to attach a custom disk image#120
Open
huguesalary wants to merge 2 commits intomachine-drivers:masterfrom
Open
Feature: --xhyve-experimental-attach-image allows to attach a custom disk image#120huguesalary wants to merge 2 commits intomachine-drivers:masterfrom
--xhyve-experimental-attach-image allows to attach a custom disk image#120huguesalary wants to merge 2 commits intomachine-drivers:masterfrom
Conversation
…thods to use a *DiskImage type This is preliminary work towards being able to attach multiple disk images
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the new --xhyve-experimental-attach-image argument, one can specify a path to an existing disk image to attach to the virtual machine.
For example:
docker-machine create -d xhyve --xhyve-experimental-attach-image ~/myDiskImage.sparsebundle test
This code might not be bullet proof. It was a quick implementation to see if it was at least feasible. It's a good starting point for anybody wanting to code this feature.
Known bug:
-sargument of xhyve. I will try to fix when I get a chance. Happy if someone else fixes it.