Switch from using hdiutil to parsing the iso file directly.#183
Open
dlorenc wants to merge 1 commit intomachine-drivers:masterfrom
Open
Switch from using hdiutil to parsing the iso file directly.#183dlorenc wants to merge 1 commit intomachine-drivers:masterfrom
dlorenc wants to merge 1 commit intomachine-drivers:masterfrom
Conversation
Member
Member
OK, I'll wait for the complete code. |
Member
|
and, /cc @praveenkumar because he wrote the related code. |
Collaborator
|
Thanks for notification, I will go through it and test. |
Collaborator
|
Tested this PR with CentOS/b2d iso and it able to extract kernel options as expected. 👍 |
Member
Collaborator
Author
|
#189, I'll rebase this one after :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm still not completely happy with this code, but I wanted to send it out early and see what you thought @zchee.