Skip to content

Fix/code quality issues#5

Open
staehlmich wants to merge 2 commits into
machinelearningZH:mainfrom
staehlmich:fix/code-quality-issues
Open

Fix/code quality issues#5
staehlmich wants to merge 2 commits into
machinelearningZH:mainfrom
staehlmich:fix/code-quality-issues

Conversation

@staehlmich

Copy link
Copy Markdown
Contributor

Changes

  • Fixed typo in utils_prompts.py
  • Removed unused excinfo variables in _tests/test_understandability.py

Type

  • Code quality

- Fix B2→B1 typo in CEFR vocabulary section
- Rename cefr variable to cefr_vocab for clarity
- Use descriptive names for example texts
@rnckp

rnckp commented May 11, 2026

Copy link
Copy Markdown
Contributor

Thanks for the cleanup.

The typo fix and unused excinfo removals look good.

Before merge, please update the branch against current main: the PR is stale and now conflicts in test_understandability.py around test_get_cefr(). The conflict should be resolved by keeping both the new get_cefr(None) is None assertion from main and the two TypeError assertions from this PR, while still removing the unused excinfo bindings.

Also, the notebook blank-line change in 03_create_dataset.ipynb is unrelated to the PR description and seems redundant. Please remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants