Fix array out of bounds error

sfsam · sfsam · commit 9885f226eb5b · 2021-01-03T19:20:26.000-08:00
* NSUInteger -1 is actually a huge positive number
  so testing i &gt;= 0 to end a loop never ends it.
diff --git a/src/MacVim/MMTabline/MMTabline.m b/src/MacVim/MMTabline/MMTabline.m
@@ -530,7 +530,7 @@ - (void)scrollTabToVisibleAtIndex:(NSUInteger)index
 - (void)scrollLeftOneTab
 {
     NSRect clipBounds = _scrollView.contentView.bounds;
-    for (NSUInteger i = _tabs.count - 1; i >= 0; i--) {
+    for (NSInteger i = _tabs.count - 1; i >= 0; i--) {
         NSRect tabFrame = _tabs[i].frame;
         if (!NSContainsRect(clipBounds, tabFrame)) {
             if (NSMinX(tabFrame) < NSMinX(clipBounds)) {

Original file line number	Diff line number	Diff line change
`@@ -530,7 +530,7 @@ - (void)scrollTabToVisibleAtIndex:(NSUInteger)index`
`530`	`530`	`- (void)scrollLeftOneTab`
`531`	`531`	`{`
`532`	`532`	`NSRect clipBounds = _scrollView.contentView.bounds;`
`533`		`- for (NSUInteger i = _tabs.count - 1; i >= 0; i--) {`
	`533`	`+ for (NSInteger i = _tabs.count - 1; i >= 0; i--) {`
`534`	`534`	`NSRect tabFrame = _tabs[i].frame;`
`535`	`535`	`if (!NSContainsRect(clipBounds, tabFrame)) {`
`536`	`536`	`if (NSMinX(tabFrame) < NSMinX(clipBounds)) {`