Function definition changes (don't create variables).

Author: Sjoerd Tieleman

lib/job-handler.js

@@ -91,7 +91,7 @@ exports.purgeJobs = function(age, callback) {
   }  
 }
 
-validateJobRequest = function(postData, callback) {
+function validateJobRequest(postData, callback) {
   // Valid job object should contain:
   //
   // source_file:       the input file
@@ -131,7 +131,7 @@ validateJobRequest = function(postData, callback) {
   }
 }
 
-spawnJob = function(opts, callback) {
+function spawnJob(opts, callback) {
   Job.create(
     opts,
     function onCreate(err, job) {
@@ -150,11 +150,11 @@ spawnJob = function(opts, callback) {
   );
 }
 
-hasFreeSlots = function() {
+function hasFreeSlots() {
   return config['slots'] - slots.length > 0;
 }
 
-removeItemFromSlot = function(item) {
+function removeItemFromSlot(item) {
   var idx = slots.indexOf(item);
   if(idx!=-1) slots.splice(idx, 1);
 }

lib/logger.js

@@ -8,7 +8,7 @@ var isWorking = true;
 var Logger = function() {
 }
 
-setupTimer = function() {
+function setupTimer() {
   // Set interval to flush buffer every 250ms
   setInterval(function() {
     if (buffer.length) {
@@ -17,11 +17,11 @@ setupTimer = function() {
   }, 250);
 }
 
-intPad = function(n) {
+function intPad(n) {
   return (n < 10 ? "0" + n.toString(10) : n.toString(10));
 }
 
-timestamp = function() {
+function timestamp() {
   var d = new Date();
   var time = [intPad(d.getHours()), intPad(d.getMinutes()), intPad(d.getSeconds())].join(':');
   return [d.getDate(), months[d.getMonth()], time].join(' ');

lib/recoverable-stream.js

@@ -23,7 +23,7 @@ RecoverableStream.prototype.end = function() {
   }
 }
 
-reopen = function() {
+function reopen() {
   stream = fs.createWriteStream(path, opts);
   stream.on('error', function(err) { logger.log('Error while logging to access_log. ' + err); stream.end(); stream.destroy(); reopen(); });
 }

lib/server.js

@@ -46,23 +46,23 @@ exports.relaunch = function() {
 }
 
 // POST /probe
-probeFile = function(request, response) {
+function probeFile(request, response) {
   var postData = "";
 
   request.on('data', function(data) { postData += data; })
   request.on('end', function() { processProbe(postData, response); } );      
 }
 
 // POST /jobs
-postNewJob = function(request, response) {
+function postNewJob(request, response) {
   var postData = "";
 
   request.on('data', function(data) { postData += data; })
   request.on('end', function() { processPostedJob(postData, response); } );    
 }
 
 // GET /jobs
-getJobs = function(request, response) {
+function getJobs(request, response) {
   var content = { max_slots: config['slots'], free_slots: jobHandler.freeSlots(), jobs: jobHandler.slots };
 
   try {
@@ -74,7 +74,7 @@ getJobs = function(request, response) {
 }
 
 // GET /jobs/:id
-getJobStatus = function(request, response) {
+function getJobStatus(request, response) {
   jobHandler.find(request.params.id, function onResult(err, job) {
     var body = {};
 
@@ -96,7 +96,7 @@ getJobStatus = function(request, response) {
 }
 
 // DELETE /jobs/:id
-removeJob = function(request, response) {
+function removeJob(request, response) {
   jobHandler.cancelAndRemove(request.params.id, function onResult(err, job) {
     var body = {};
 
@@ -123,7 +123,7 @@ removeJob = function(request, response) {
 }
 
 // DELETE /jobs/purge
-purgeJobs = function(request, response) {
+function purgeJobs(request, response) {
   jobHandler.purgeJobs(request.params.age, function onPurge(err, count) {
     var body = {};
     if (err) {
@@ -143,7 +143,7 @@ purgeJobs = function(request, response) {
   });
 }
 
-rejectRequestDueToLogger = function(response) {
+function rejectRequestDueToLogger(response) {
   var body = {};
   body['message'] = rejectLoggerMessage;
   response.statusCode = 503;
@@ -155,7 +155,7 @@ rejectRequestDueToLogger = function(response) {
   }
 }
 
-processPostedJob = function(postData, response) {
+function processPostedJob(postData, response) {
   response.setHeader('Content-Type', 'application/json; charset=utf-8');
 
   if (!logger.isWorking()) {
@@ -198,7 +198,7 @@ processPostedJob = function(postData, response) {
   }
 }
 
-processProbe = function(postData, response) {
+function processProbe(postData, response) {
   response.setHeader('Content-Type', 'application/json; charset=utf-8');
   var body = {};