Remove NSObject special-casing

The cases where this triggered was strictly incorrect, and not really
necessary anyway.

Author: madsmtm

crates/header-translator/src/id.rs

@@ -288,11 +288,6 @@ impl ItemIdentifier {
         self.map_name(Some)
     }
 
-    pub fn is_nsobject(&self) -> bool {
-        self.library_name() == "objc2"
-            && (self.name == "NSObject" || self.name == "NSObjectProtocol")
-    }
-
     pub fn is_nserror(&self) -> bool {
         self.library_name() == "Foundation" && self.name == "NSError"
     }

crates/header-translator/src/rust_type.rs

@@ -1416,7 +1416,6 @@ impl Ty {
             Self::GenericParam { name } => write!(f, "{name}"),
             Self::AnyObject { protocols } => match &**protocols {
                 [] => write!(f, "AnyObject"),
-                [decl] if decl.id.is_nsobject() => write!(f, "NSObject"),
                 [decl] => write!(f, "ProtocolObject<dyn {}>", decl.id.path()),
                 // TODO: Handle this better
                 [first, rest @ ..] => {

crates/header-translator/src/stmt.rs

@@ -1854,7 +1854,7 @@ impl Stmt {
                             // The object inherits from `NSObject` or `NSProxy` no
                             // matter what the generic type is, so this must be
                             // safe.
-                            (_, _) if protocol.is_nsobject() => ("?Sized", None),
+                            ("Foundation", "NSObjectProtocol") => ("?Sized", None),
                             // Encoding and decoding requires that the inner types
                             // are codable as well.
                             ("Foundation", "NSCoding") => ("?Sized + NSCoding", None),

crates/objc2/src/topics/about_generated/CHANGELOG.md

@@ -76,6 +76,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
   of `"LAContext"`.
 * **BREAKING**: Cfg-gated `HKAudiogramSensitivityPoint` behind
   `"HKAudiogramSensitivityPoint"` instead of `"HKAudiogramSample"`.
+* **BREAKING**: No longer special-case `NSObjectProtocol` objects. Certain
+  methods that previously used `&NSObject` for convenience now use the more
+  correct `&ProtocolObject<dyn NSObjectProtocol>`.
 
 ### Deprecated
 * Moved `MainThreadMarker` from `objc2-foundation` to `objc2`.