fix: move *.svg to LF-forced text section in .gitattributes#1902
Merged
Conversation
Up to standards ✅🟢 Issues
|
Deploying maester with
|
| Latest commit: |
10f69df
|
| Status: | ⚡️ Build in progress... |
Copilot
AI
changed the title
[WIP] Fix code based on review comments
fix: move *.svg to LF-forced text section in .gitattributes
Jul 2, 2026
SamErde
approved these changes
Jul 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the repository’s .gitattributes rules to treat SVG files as LF-forced text assets (rather than “binary”), aligning the attributes with SVG’s XML/text nature and ensuring consistent line endings across platforms.
Changes:
- Moves
*.svginto the “always LF” text section viatext eol=lf. - Simplifies the “Binary files” header to reflect that it now contains only true binary formats.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
SamErde
approved these changes
Jul 2, 2026
# Conflicts: # .gitattributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Addresses review feedback on the
.gitattributesintroduced in this PR:*.svgwas listed under the# Binary filessection astext, which was both semantically wrong (SVG is XML) and failed to enforce LF in the working tree.Changes:
*.svgfrom the binary section to the LF-forced text section witheol=lf, consistent with other cross-platform text assets# Binary files (and other non-source assets).to# Binary files.— it now contains only true binary formats✅ Checks
/powershell/tests/pester.ps1locally.ℹ️ Additional Information
No functional behavior change for binary assets. SVG files will now have LF enforced in the working tree, consistent with other text-based source formats.
How to Contribute
🏗️ Read our full contributing guide for the Maester project.
🧪 We also have additional instructions and a checklist for creating tests.
Join us at the Maester repository discussions or Entra Discord for more help and conversations!
While you wait for a review, why not spread some Maester love on social media? Thank you! 💖