Skip to content

Commit 0d26337

Browse files
authored
Fix opensearch versions based on container support (#289)
* Fix opensearch versions based on wardenenv container support * opensearchproject/opensearch:2.19.1 * Disable opensearch security * spawn separate opensearch service when needed * fix opensearch flags; fix PackageMatrixVersion type and test * Try mysql:8.4 over mariadb:11.4 * updated dist/index.js * Allow trigger creation during integration tests
1 parent 452d6af commit 0d26337

8 files changed

Lines changed: 63 additions & 18 deletions

File tree

.github/workflows/integration.yaml

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ jobs:
6464
matrix: ${{ fromJSON(inputs.matrix) }}
6565
services:
6666
elasticsearch:
67-
image: ${{ matrix.elasticsearch }}
67+
image: ${{ matrix.elasticsearch || '' }}
6868
env:
6969
# By default, ElasticSearch refuses to spawn in single node configuration, as it expects redundancy.
7070
# This is a dev environment, so redundancy is just wasteful.
@@ -83,6 +83,24 @@ jobs:
8383
ports:
8484
- 9200:9200
8585

86+
opensearch:
87+
image: ${{ matrix.opensearch || '' }}
88+
env:
89+
# By default, ElasticSearch refuses to spawn in single node configuration, as it expects redundancy.
90+
# This is a dev environment, so redundancy is just wasteful.
91+
discovery.type: single-node
92+
# Disable HTTPS and password authentication
93+
DISABLE_INSTALL_DEMO_CONFIG: true
94+
DISABLE_SECURITY_PLUGIN: true
95+
96+
options: >-
97+
--health-cmd "curl http://localhost:9200/_cluster/health"
98+
--health-interval 10s
99+
--health-timeout 5s
100+
--health-retries 10
101+
ports:
102+
- 9200:9200
103+
86104
mysql:
87105
image: ${{ matrix.mysql }}
88106
env:
@@ -110,6 +128,10 @@ jobs:
110128
tools: composer:v${{ matrix.composer }}
111129
coverage: none
112130

131+
- name: Allow SQL triggers
132+
run: |
133+
mysql --host 127.0.0.1 --port ${{ job.services.mysql.ports['3306'] }} -u root -prootpassword -e "set global log_bin_trust_function_creators=1;"
134+
113135
- run: composer create-project --repository-url="${{ inputs.magento_repository }}" "${{ matrix.magento }}" ${{ inputs.magento_directory }} --no-install
114136
shell: bash
115137
env:

supported-version/dist/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

supported-version/src/matrix/matrix-type.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,11 @@ export interface PackageMatrixVersion {
44
composer: string | number,
55
mysql: string,
66
elasticsearch: string,
7+
opensearch: string,
78
rabbitmq: string,
89
redis: string,
910
varnish: string,
11+
valkey: string,
1012
nginx: string,
1113
os: string,
1214
release: string,

supported-version/src/nightly/amend-matrix-for-next.spec.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,10 @@ describe('amendMatrixForNext', () => {
1212
"composer": "2",
1313
"mysql": "mysql:8.0",
1414
"elasticsearch": "elasticsearch:8.5.3",
15+
"opensearch": "",
1516
"rabbitmq": "rabbitmq:3.11-management",
1617
"redis": "redis:7.0",
18+
"valkey": "",
1719
"varnish": "varnish:7.3",
1820
"nginx": "nginx:1.22",
1921
"os": "ubuntu-latest",
@@ -35,8 +37,10 @@ describe('amendMatrixForNext', () => {
3537
"composer": "2",
3638
"mysql": "mysql:8.0",
3739
"elasticsearch": "elasticsearch:8.5.3",
40+
"opensearch": "",
3841
"rabbitmq": "rabbitmq:3.11-management",
3942
"redis": "redis:7.0",
43+
"valkey": "",
4044
"varnish": "varnish:7.3",
4145
"nginx": "nginx:1.22",
4246
"os": "ubuntu-latest",
@@ -60,8 +64,10 @@ describe('amendMatrixForNext', () => {
6064
"composer": "2",
6165
"mysql": "mysql:8.0",
6266
"elasticsearch": "elasticsearch:8.5.3",
67+
"opensearch": "",
6368
"rabbitmq": "rabbitmq:3.11-management",
6469
"redis": "redis:7.0",
70+
"valkey": "",
6571
"varnish": "varnish:7.3",
6672
"nginx": "nginx:1.22",
6773
"os": "ubuntu-latest",
@@ -83,8 +89,10 @@ describe('amendMatrixForNext', () => {
8389
"composer": "2",
8490
"mysql": "mysql:8.0",
8591
"elasticsearch": "elasticsearch:8.5.3",
92+
"opensearch": "",
8693
"rabbitmq": "rabbitmq:3.11-management",
8794
"redis": "redis:7.0",
95+
"valkey": "",
8896
"varnish": "varnish:7.3",
8997
"nginx": "nginx:1.22",
9098
"os": "ubuntu-latest",
@@ -108,8 +116,10 @@ describe('amendMatrixForNext', () => {
108116
"composer": "2",
109117
"mysql": "mysql:8.0",
110118
"elasticsearch": "elasticsearch:8.5.3",
119+
"opensearch": "",
111120
"rabbitmq": "rabbitmq:3.11-management",
112121
"redis": "redis:7.0",
122+
"valkey": "",
113123
"varnish": "varnish:7.3",
114124
"nginx": "nginx:1.22",
115125
"os": "ubuntu-latest",
@@ -122,8 +132,10 @@ describe('amendMatrixForNext', () => {
122132
"composer": "2",
123133
"mysql": "mysql:8.0",
124134
"elasticsearch": "elasticsearch:8.5.3",
135+
"opensearch": "",
125136
"rabbitmq": "rabbitmq:3.11-management",
126137
"redis": "redis:7.0",
138+
"valkey": "",
127139
"varnish": "varnish:7.3",
128140
"nginx": "nginx:1.22",
129141
"os": "ubuntu-latest",
@@ -145,8 +157,10 @@ describe('amendMatrixForNext', () => {
145157
"composer": "2",
146158
"mysql": "mysql:8.0",
147159
"elasticsearch": "elasticsearch:8.5.3",
160+
"opensearch": "",
148161
"rabbitmq": "rabbitmq:3.11-management",
149162
"redis": "redis:7.0",
163+
"valkey": "",
150164
"varnish": "varnish:7.3",
151165
"nginx": "nginx:1.22",
152166
"os": "ubuntu-latest",
@@ -159,8 +173,10 @@ describe('amendMatrixForNext', () => {
159173
"composer": "2",
160174
"mysql": "mysql:8.0",
161175
"elasticsearch": "elasticsearch:8.5.3",
176+
"opensearch": "",
162177
"rabbitmq": "rabbitmq:3.11-management",
163178
"redis": "redis:7.0",
179+
"valkey": "",
164180
"varnish": "varnish:7.3",
165181
"nginx": "nginx:1.22",
166182
"os": "ubuntu-latest",
@@ -184,8 +200,10 @@ describe('amendMatrixForNext', () => {
184200
"composer": "2",
185201
"mysql": "mysql:8.0",
186202
"elasticsearch": "elasticsearch:8.5.3",
203+
"opensearch": "",
187204
"rabbitmq": "rabbitmq:3.11-management",
188205
"redis": "redis:7.0",
206+
"valkey": "",
189207
"varnish": "varnish:7.3",
190208
"nginx": "nginx:1.22",
191209
"os": "ubuntu-latest",
@@ -207,8 +225,10 @@ describe('amendMatrixForNext', () => {
207225
"composer": "2",
208226
"mysql": "mysql:8.0",
209227
"elasticsearch": "elasticsearch:8.5.3",
228+
"opensearch": "",
210229
"rabbitmq": "rabbitmq:3.11-management",
211230
"redis": "redis:7.0",
231+
"valkey": "",
212232
"varnish": "varnish:7.3",
213233
"nginx": "nginx:1.22",
214234
"os": "ubuntu-latest",

supported-version/src/versions/mage-os/composite.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
"magento": "mage-os/project-community-edition:>=1.1 <1.2",
1818
"php": 8.4,
1919
"composer": "2.8.8",
20-
"mysql": "mariadb:11.4",
21-
"elasticsearch": "opensearch:2.19.1",
20+
"mysql": "mysql:8.4",
21+
"opensearch": "opensearchproject/opensearch:2.19.1",
2222
"rabbitmq": "rabbitmq:4.0-management",
2323
"redis": "redis:7.2",
2424
"varnish": "varnish:7.6",
@@ -31,8 +31,8 @@
3131
"magento": "mage-os/project-community-edition",
3232
"php": 8.4,
3333
"composer": "2.8.8",
34-
"mysql": "mariadb:11.4",
35-
"elasticsearch": "opensearch:2.19.1",
34+
"mysql": "mysql:8.4",
35+
"opensearch": "opensearchproject/opensearch:2.19.1",
3636
"rabbitmq": "rabbitmq:4.0-management",
3737
"redis": "redis:7.2",
3838
"varnish": "varnish:7.6",
@@ -45,8 +45,8 @@
4545
"magento": "mage-os/project-community-edition:next",
4646
"php": 8.4,
4747
"composer": "2.8.8",
48-
"mysql": "mariadb:11.4",
49-
"elasticsearch": "opensearch:2.19.1",
48+
"mysql": "mysql:8.4",
49+
"opensearch": "opensearchproject/opensearch:2.19.1",
5050
"rabbitmq": "rabbitmq:4.0-management",
5151
"redis": "redis:7.2",
5252
"varnish": "varnish:7.6",

supported-version/src/versions/mage-os/individual.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@
101101
"magento": "mage-os/project-community-edition:1.1.0",
102102
"php": 8.4,
103103
"composer": "2.8.8",
104-
"mysql": "mariadb:11.4",
105-
"elasticsearch": "opensearch:2.19.1",
104+
"mysql": "mysql:8.4",
105+
"opensearch": "opensearchproject/opensearch:2.19.1",
106106
"rabbitmq": "rabbitmq:4.0-management",
107107
"redis": "redis:7.2",
108108
"varnish": "varnish:7.6",

supported-version/src/versions/magento-open-source/composite.json

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,8 @@
129129
"magento": "magento/project-community-edition:>=2.4.8 <2.4.9",
130130
"php": 8.4,
131131
"composer": "2.8.8",
132-
"mysql": "mariadb:11.4",
133-
"elasticsearch": "opensearch:2.19.1",
132+
"mysql": "mysql:8.4",
133+
"opensearch": "opensearchproject/opensearch:2.19.1",
134134
"rabbitmq": "rabbitmq:4.0-management",
135135
"redis": "redis:7.2",
136136
"varnish": "varnish:7.6",
@@ -143,8 +143,8 @@
143143
"magento": "magento/project-community-edition:>=2.4.8 <2.4.9",
144144
"php": 8.4,
145145
"composer": "2.8.8",
146-
"mysql": "mariadb:11.4",
147-
"elasticsearch": "opensearch:2.19.1",
146+
"mysql": "mysql:8.4",
147+
"opensearch": "opensearchproject/opensearch:2.19.1",
148148
"rabbitmq": "rabbitmq:4.0-management",
149149
"redis": "redis:7.2",
150150
"varnish": "varnish:7.6",
@@ -157,9 +157,10 @@
157157
"magento": "magento/project-community-edition:next",
158158
"php": 8.4,
159159
"composer": "2.8.8",
160-
"mysql": "mariadb:11.4",
161-
"elasticsearch": "opensearch:2.19.1",
160+
"mysql": "mysql:8.4",
161+
"opensearch": "opensearchproject/opensearch:2.19.1",
162162
"rabbitmq": "rabbitmq:4.0-management",
163+
"redis": "redis:7.2",
163164
"varnish": "varnish:7.6",
164165
"nginx": "nginx:1.26",
165166
"os": "ubuntu-latest",

supported-version/src/versions/magento-open-source/individual.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -801,8 +801,8 @@
801801
"magento": "magento/project-community-edition:2.4.8",
802802
"php": 8.4,
803803
"composer": "2.8.8",
804-
"mysql": "mariadb:11.4",
805-
"elasticsearch": "opensearch:2.19.1",
804+
"mysql": "mysql:8.4",
805+
"opensearch": "opensearchproject/opensearch:2.19.1",
806806
"rabbitmq": "rabbitmq:4.0-management",
807807
"redis": "redis:7.2",
808808
"varnish": "varnish:7.6",

0 commit comments

Comments
 (0)