Skip to content

Commit f9f4ef4

Browse files
digitalrisedorsetHerve Tribouilloy
andauthored
feat(setup-magento)!: change extension working dir to _ghamagento (#367)
BREAKING CHANGE: Previously, when using setup-magento in extension mode, the magento 2 repo root was ../magento2 (outside of the extension folder). Due to interactions with `cache-magento` we need to keep magento inside the GITHUB_WORKSPACE (the root repo). We now do this in the `_ghamagento` folder. If you rely on the `steps.setup-magento.outputs.path` nothing changes for you. But, if you hardcoded the path, it's likely broken. Co-authored-by: Herve Tribouilloy <herve@digitalrisedorset.co.uk>
1 parent f54dcc5 commit f9f4ef4

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

setup-magento/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ runs:
6969
- run: |
7070
MAGENTO_DIRECTORY=""
7171
if [ "${{ inputs.mode }}" = 'extension' ]; then
72-
MAGENTO_DIRECTORY="../magento2"
72+
MAGENTO_DIRECTORY="_ghamagento"
7373
else
7474
MAGENTO_DIRECTORY="${{ inputs.working-directory }}"
7575
fi

0 commit comments

Comments
 (0)