feat: defer config saving and use namespaced item IDs

Introduces a deferred saving mechanism for dynamic skills and classes during startup, queuing file writes to execute asynchronously after initial registration. This reduces synchronous I/O and improves loading performance.

Additionally, updates item data serialization to use namespaced IDs, ensuring consistent and robust identification of items.

Author: Travja

src/main/java/studio/magemonkey/fabled/api/util/Data.java

@@ -98,7 +98,7 @@ public static void serializeIcon(ItemStack item, DataSection config) {
         CodexItemManager itemManager = CodexEngine.get().getItemManager();
         ItemType         itemType    = itemManager.getMainItemType(item);
         if (itemType != null) {
-            config.set(MAT, itemType.getID());
+            config.set(MAT, itemType.getNamespacedID());
         } else {
             config.set(MAT, item.getType().name());
         }

src/main/java/studio/magemonkey/fabled/manager/RegistrationManager.java

@@ -46,6 +46,8 @@
 import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
+import java.util.ArrayList;
+import java.util.List;
 
 /**
  * <p>Skill API Registration Manager.</p>
@@ -61,6 +63,7 @@ public class RegistrationManager {
     private final        Fabled          api;
     private final        CommentedConfig skillConfig;
     private final        CommentedConfig classConfig;
+    private final        List<DeferredSave> deferredSaves = new ArrayList<>();
     private              Mode            mode         = Mode.STARTUP;
 
     /**
@@ -171,21 +174,17 @@ public void initialize() {
                     continue;
                 }
                 try {
-                    DynamicSkill skill = new DynamicSkill(key);
-                    skill.load(skillConfig.getConfig().getSection(key));
-                    if (!Fabled.isSkillRegistered(skill.getName())) {
-                        api.addDynamicSkill(skill);
-                        skill.registerEvents(api);
-                        String path = getPath(Fabled.inst().getDataFolder() + File.separator + SKILL_DIR, key);
-                        if (path == null) path = key;
-                        CommentedConfig sConfig = new CommentedConfig(api, SKILL_DIR + path);
-                        sConfig.clear();
-                        skill.save(sConfig.getConfig().createSection(key));
-                        skill.save(skillConfig.getConfig().createSection(key));
-                        sConfig.save();
-                        Logger.log(LogType.REGISTRATION, 2, "Loaded the dynamic skill: " + key);
-                    } else {
-                        Logger.invalid("Duplicate skill detected: " + key);
+                        DynamicSkill skill = new DynamicSkill(key);
+                        skill.load(skillConfig.getConfig().getSection(key));
+                        if (!Fabled.isSkillRegistered(skill.getName())) {
+                            api.addDynamicSkill(skill);
+                            skill.registerEvents(api);
+                            String path = getPath(Fabled.inst().getDataFolder() + File.separator + SKILL_DIR, key);
+                            if (path == null) path = key;
+                            queueDynamicSkillSave(skill, path, key);
+                            Logger.log(LogType.REGISTRATION, 2, "Loaded the dynamic skill: " + key);
+                        } else {
+                            Logger.invalid("Duplicate skill detected: " + key);
                     }
                 } catch (Exception ex) {
                     Logger.invalid("Failed to load skill: " + key + " - " + ex.getMessage());
@@ -214,10 +213,7 @@ public void initialize() {
                         if (!Fabled.isSkillRegistered(skill.getName())) {
                             api.addDynamicSkill(skill);
                             skill.registerEvents(api);
-                            sConfig.clear();
-                            skill.save(sConfig.getConfig().createSection(name));
-                            skill.save(skillConfig.getConfig().createSection(name));
-                            sConfig.save();
+                            queueDynamicSkillSave(skill, longName, name);
                             Logger.log(LogType.REGISTRATION, 2, "Loaded the dynamic skill: " + name);
                         } else if (Fabled.getSkill(name) instanceof DynamicSkill) {
                             Logger.log(LogType.REGISTRATION, 3, name + " is already loaded, skipping it");
@@ -263,20 +259,16 @@ public void initialize() {
                     continue;
                 }
                 try {
-                    DynamicClass tree = new DynamicClass(api, key);
-                    tree.load(classConfig.getConfig().getSection(key));
-                    if (!Fabled.isClassRegistered(tree.getName())) {
-                        api.addDynamicClass(tree);
-                        String path = getPath(Fabled.inst().getDataFolder() + File.separator + CLASS_DIR, key);
-                        if (path == null) path = key;
-                        CommentedConfig cConfig = new CommentedConfig(api, CLASS_DIR + path);
-                        cConfig.clear();
-                        tree.save(cConfig.getConfig().createSection(key));
-                        tree.save(classConfig.getConfig().createSection(key));
-                        cConfig.save();
-                        Logger.log(LogType.REGISTRATION, 2, "Loaded the dynamic class: " + key);
-                    } else {
-                        Logger.invalid("Duplicate class detected: " + key);
+                        DynamicClass tree = new DynamicClass(api, key);
+                        tree.load(classConfig.getConfig().getSection(key));
+                        if (!Fabled.isClassRegistered(tree.getName())) {
+                            api.addDynamicClass(tree);
+                            String path = getPath(Fabled.inst().getDataFolder() + File.separator + CLASS_DIR, key);
+                            if (path == null) path = key;
+                            queueDynamicClassSave(tree, path, key);
+                            Logger.log(LogType.REGISTRATION, 2, "Loaded the dynamic class: " + key);
+                        } else {
+                            Logger.invalid("Duplicate class detected: " + key);
                     }
                 } catch (Exception ex) {
                     Logger.invalid("Failed to load class \"" + key + "\"");
@@ -304,10 +296,7 @@ public void initialize() {
                         tree.load(section);
                         if (!Fabled.isClassRegistered(tree.getName())) {
                             api.addDynamicClass(tree);
-                            cConfig.clear();
-                            tree.save(cConfig.getConfig().createSection(name));
-                            tree.save(classConfig.getConfig().createSection(name));
-                            cConfig.save();
+                            queueDynamicClassSave(tree, longName, name);
                             Logger.log(LogType.REGISTRATION, 2, "Loaded the dynamic class: " + name);
                         } else if (Fabled.getClass(name) instanceof DynamicClass) {
                             Logger.log(LogType.REGISTRATION, 3, name + " is already loaded, skipping it");
@@ -338,6 +327,68 @@ public void initialize() {
         Logger.log(LogType.REGISTRATION, 0, " - " + Fabled.getSkills().size() + " skills");
         Logger.log(LogType.REGISTRATION, 0, " - " + Fabled.getClasses().size() + " classes");
         Logger.log(LogType.REGISTRATION, 0, " Took " + (System.currentTimeMillis() - start) + "ms");
+        Bukkit.getScheduler().runTask(api, this::flushDeferredSaves);
+    }
+
+    private void queueDeferredSave(String description, Runnable saveTask) {
+        deferredSaves.add(new DeferredSave(description, saveTask));
+    }
+
+    private void flushDeferredSaves() {
+        if (deferredSaves.isEmpty()) return;
+
+        List<DeferredSave> savesToRun = new ArrayList<>(deferredSaves);
+        deferredSaves.clear();
+
+        for (DeferredSave deferredSave : savesToRun) {
+            try {
+                deferredSave.saveTask.run();
+            } catch (Exception ex) {
+                Logger.bug("Failed to save deferred " + deferredSave.description);
+                ex.printStackTrace();
+            }
+        }
+
+        skillConfig.save();
+        classConfig.save();
+    }
+
+    private void queueSkillFileSave(Skill skill) {
+        String skillName = skill.getName();
+        queueDeferredSave("skill \"" + skillName + "\"", () -> {
+            CommentedConfig singleFile = new CommentedConfig(api, "skill" + File.separator + skillName);
+            skill.save(singleFile.getConfig());
+            singleFile.save();
+        });
+    }
+
+    private void queueClassFileSave(FabledClass fabledClass) {
+        String className = fabledClass.getName();
+        queueDeferredSave("class \"" + className + "\"", () -> {
+            CommentedConfig singleFile = new CommentedConfig(api, "class" + File.separator + className);
+            fabledClass.save(singleFile.getConfig());
+            singleFile.save();
+        });
+    }
+
+    private void queueDynamicSkillSave(DynamicSkill skill, String path, String key) {
+        queueDeferredSave("dynamic skill \"" + key + "\"", () -> {
+            CommentedConfig singleFile = new CommentedConfig(api, SKILL_DIR + path);
+            singleFile.clear();
+            skill.save(singleFile.getConfig().createSection(key));
+            skill.save(skillConfig.getConfig().createSection(key));
+            singleFile.save();
+        });
+    }
+
+    private void queueDynamicClassSave(DynamicClass tree, String path, String key) {
+        queueDeferredSave("dynamic class \"" + key + "\"", () -> {
+            CommentedConfig singleFile = new CommentedConfig(api, CLASS_DIR + path);
+            singleFile.clear();
+            tree.save(singleFile.getConfig().createSection(key));
+            tree.save(classConfig.getConfig().createSection(key));
+            singleFile.save();
+        });
     }
 
     private String getQualifiedFileName(Path root, Path path) {
@@ -405,15 +456,10 @@ else if (Fabled.isSkillRegistered(skill.getName())) {
             DataSection     config     = singleFile.getConfig();
 
             try {
-                // Soft save to ensure optional data starts off in the config
-                skill.softSave(config);
-
-                // Load the config data to apply any previous data
-                skill.load(config);
-
-                // Finally, do a full save to make sure the config is up to date
-                skill.save(config);
-                singleFile.save();
+                if (!config.keys().isEmpty()) {
+                    skill.load(config);
+                }
+                queueSkillFileSave(skill);
 
                 if (skill instanceof Listener) {
                     Bukkit.getServer().getPluginManager().registerEvents((Listener) skill, api);
@@ -463,16 +509,10 @@ else if (Fabled.isClassRegistered(fabledClass.getName())) {
             DataSection     config     = singleFile.getConfig();
 
             try {
-
-                // Soft save to ensure optional data starts off in the config
-                fabledClass.softSave(config);
-
-                // Load the config data to apply any previous data
-                fabledClass.load(config);
-
-                // Finally, do a full save to make sure the config is up to date
-                fabledClass.save(config);
-                singleFile.save();
+                if (!config.keys().isEmpty()) {
+                    fabledClass.load(config);
+                }
+                queueClassFileSave(fabledClass);
 
                 // Skill is ready to be registered
                 return fabledClass;
@@ -504,4 +544,14 @@ public enum Mode {
         DYNAMIC,
         DONE
     }
+
+    private static class DeferredSave {
+        private final String   description;
+        private final Runnable saveTask;
+
+        private DeferredSave(String description, Runnable saveTask) {
+            this.description = description;
+            this.saveTask = saveTask;
+        }
+    }
 }