Skip to content

feat: Display Entity mechanic support (1.19.4+)#1647

Draft
Copilot wants to merge 16 commits intodevfrom
copilot/add-support-for-display-entities
Draft

feat: Display Entity mechanic support (1.19.4+)#1647
Copilot wants to merge 16 commits intodevfrom
copilot/add-support-for-display-entities

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 25, 2026

  • Read current code in DisplayEntityMechanic and DisplayEntityInstance
  • execute(): use flattened horizDir for forward offset when follow=false, full 3D dir when follow=true; pass forwardDir as castDir to constructor for consistency
  • playPreview(): read follow setting, apply same branch
  • DisplayEntityInstance.castDir Javadoc updated to note the follow-based duality
  • DisplayEntityInstance.tick(): already inside if (follow) block — no change needed

Copilot AI changed the title [WIP] Add support for display entities in SkillApi feat: Display Entity mechanic support (1.19.4+) Apr 25, 2026
Copilot AI requested a review from Travja April 25, 2026 18:50
Copilot AI and others added 2 commits April 25, 2026 19:10
- Add DisplayEntityTransform: holds 12 Formula objects (scale-x/y/z,
  translate-x/y/z, left-rotation-x/y/z, right-rotation-x/y/z) with
  t (elapsed ticks) and l (skill level) as variables
- Update DisplayEntityInstance: stores the transform, level, tick
  counter, and interpolation duration; applies transform.compute(t, l)
  each tick via Bukkit main-thread runTask
- Update DisplayEntityMechanic: builds a DisplayEntityTransform from
  settings strings instead of a one-shot static Transformation; adds
  interpolation-duration setting for smooth client-side animation

Agent-Logs-Url: https://github.com/magemonkeystudio/fabled/sessions/e0457758-fbef-483c-a7ff-3d33104656af

Co-authored-by: Travja <1574947+Travja@users.noreply.github.com>
Resolves item-material names via CodexItemManager.getItemType() before
falling back to vanilla Material, enabling custom item providers such as
Divinity, Nexo, and any other provider registered with Codex to be used
as the displayed item in an item display entity.

Agent-Logs-Url: https://github.com/magemonkeystudio/fabled/sessions/69961564-e033-46f3-881e-f3ee548a7be4

Co-authored-by: Travja <1574947+Travja@users.noreply.github.com>
…ity mechanic

- inherit-rotation (default true): when false, spawn location and follow-teleport
  locations have yaw/pitch zeroed so the entity does not inherit the caster's
  facing direction
- center-rotation (default false): when true, the translation is automatically
  adjusted each tick so the visual centre of the block (or item/text) sits at
  the entity's world position; user translate-x/y/z become additive offsets from
  that centre rather than from the corner. Handles both left- and right-rotation
  including time-animated formulas.

Agent-Logs-Url: https://github.com/magemonkeystudio/fabled/sessions/7dfc4bb5-768c-40c5-a799-f1ceb08d578a

Co-authored-by: Travja <1574947+Travja@users.noreply.github.com>
Copilot AI and others added 2 commits April 26, 2026 02:53
…otation=false; add follow teleport interpolation

Agent-Logs-Url: https://github.com/magemonkeystudio/fabled/sessions/3f7f10ba-f6d1-47e8-b58b-c521b8f92a9a

Co-authored-by: Travja <1574947+Travja@users.noreply.github.com>
…set formulas to DisplayEntity

Agent-Logs-Url: https://github.com/magemonkeystudio/fabled/sessions/ba015f6d-abf0-4d80-a58a-8320a69db2ef

Co-authored-by: Travja <1574947+Travja@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Support for Display Entities (1.19)

2 participants