Commit 3f03ca1
committed
docs(WalletBase): note SignMessage(null) overload ambiguity
CodeRabbit flagged that adding SignMessage(string) creates a CS0121
overload-resolution ambiguity for callers passing a literal null, since
null is implicitly convertible to both byte[] and string. The runtime
null guard already throws ArgumentNullException for the string overload,
and the byte[] overload predates this PR, so renaming would break the
expected C# overload pattern. Documented the limitation per CodeRabbit's
first suggestion so external consumers know to cast (byte[])null or
(string)null when they need to.1 parent e7d3f9a commit 3f03ca1
1 file changed
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
270 | 270 | | |
271 | 271 | | |
272 | 272 | | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
273 | 280 | | |
274 | 281 | | |
275 | 282 | | |
| |||
0 commit comments