-
Notifications
You must be signed in to change notification settings - Fork 127
Auth 2.0 SIWS (Sign In With Solana) #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mstevens843
wants to merge
4
commits into
magicblock-labs:main
Choose a base branch
from
mstevens843:feat/authorize-mwa-2.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4d6e6e5
feat(MWA): add MWA 2.0 authorize with SIWS (Sign In With Solana)
mstevens843 9c0201a
added steps 2 and 3 for react parity. SIWS was missing the fallback. …
mstevens843 590ac16
fix: CloseAssociation null guard and MinContextSlot type (CodeRabbit…
mstevens843 af06468
fix(mwa): address CodeRabbit feedback on Auth 2.0 SIWS PR
mstevens843 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
Runtime/codebase/SolanaMobileStack/JsonRpcClient/Responses/CapabilitiesResult.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
20 changes: 20 additions & 0 deletions
20
Runtime/codebase/SolanaMobileStack/JsonRpcClient/Responses/SignAndSendResult.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using Newtonsoft.Json; | ||
| using UnityEngine.Scripting; | ||
|
|
||
| // ReSharper disable once CheckNamespace | ||
|
|
||
| [Preserve] | ||
| public class SignAndSendResult | ||
| { | ||
| [JsonProperty("signatures")] | ||
| [RequiredMember] | ||
| public List<string> Signatures { get; set; } | ||
|
|
||
| [RequiredMember] | ||
| public List<byte[]> SignaturesBytes => Signatures is { Count: > 0 } | ||
| ? Signatures.Select(Convert.FromBase64String).ToList() | ||
| : new List<byte[]>(); | ||
| } |
2 changes: 2 additions & 0 deletions
2
Runtime/codebase/SolanaMobileStack/JsonRpcClient/Responses/SignAndSendResult.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
24 changes: 24 additions & 0 deletions
24
Runtime/codebase/SolanaMobileStack/JsonRpcClient/Responses/SignInResult.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| using Newtonsoft.Json; | ||
| using UnityEngine.Scripting; | ||
|
|
||
| // ReSharper disable once CheckNamespace | ||
|
|
||
| [Preserve] | ||
| public class SignInResult | ||
| { | ||
| [JsonProperty("address")] | ||
| [RequiredMember] | ||
| public string Address { get; set; } | ||
|
|
||
| [JsonProperty("signed_message")] | ||
| [RequiredMember] | ||
| public string SignedMessage { get; set; } | ||
|
|
||
| [JsonProperty("signature")] | ||
| [RequiredMember] | ||
| public string Signature { get; set; } | ||
|
|
||
| [JsonProperty("signature_type")] | ||
| [RequiredMember] | ||
| public string SignatureType { get; set; } | ||
| } |
2 changes: 2 additions & 0 deletions
2
Runtime/codebase/SolanaMobileStack/JsonRpcClient/Responses/SignInResult.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.