Open
fix: clear render and text caches on theme change in PassPolarPlotControl#64
Conversation
Copilot
AI
changed the title
[WIP] Fix code as per review comment
fix: clear render and text caches on theme change in PassPolarPlotControl
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PassPolarPlotControlcachedFormattedTextand render resources (SolidColorBrush,Pen) but never invalidated those caches on theme change, causing N/E/S/W cardinal labels and plot geometry to render with stale palette colours after switching themes.Changes
PassPolarPlotControl— overridesOnAttachedToVisualTree/OnDetachedFromVisualTreeto subscribe/unsubscribe fromActualThemeVariantChanged, clearing_renderCacheand_textCacheon each theme switch. Mirrors the existing pattern inSkyPlotControlandWorldMapControl.FormattedTextCache— theGet(name, fontSize, Color foreground)overload used only(name, fontSize)as the cache key, so a colour change for the same text+size silently returned a stale entry. Key expanded to(name, fontSize, foreground):