Commit 532e24d
committed
Bring Symbols enum and module-base docs back in line with reality
Three small consistency fixes surfaced by a code-review pass:
- Symbols::Birth comment said "asterisk" but the value is BLACK STAR
(★, U+2605). Update the comment so a future reader doesn't switch
to a literal "*" and silently change the rendered glyph.
- MARRIAGE_DATE_UNKNOWN was a `public const string` on a backed enum
while every other entry is a real case, forcing consumers to drop
->value at the one call site. Promote it to `case MarriageDateUnknown`
so cases() / from() / value access stay uniform; updated the single
upstream consumer (DateProcessor) to use ->value.
- README.md and AGENTS.md still advertised Model/Node + Model/NodeData
even though those classes only live inside the chart-module repos
and were never part of module-base. Replace with the actual public
surface (Symbols enum + NameAbbreviation strategy enum). Sister
AGENTS.md files in the three chart modules were sed-fixed for the
matching MarriageDateUnknown rename in their respective repos.1 parent 470427c commit 532e24d
4 files changed
Lines changed: 9 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
43 | | - | |
| 42 | + | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
55 | | - | |
| 54 | + | |
| 55 | + | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
284 | 284 | | |
285 | 285 | | |
286 | 286 | | |
287 | | - | |
| 287 | + | |
288 | 288 | | |
289 | 289 | | |
290 | 290 | | |
| |||
300 | 300 | | |
301 | 301 | | |
302 | 302 | | |
303 | | - | |
| 303 | + | |
304 | 304 | | |
305 | 305 | | |
306 | 306 | | |
| |||
0 commit comments