Commit 5f7970f
committed
forge--github-repository-query: Shift pagination point
Github might chose to paginate at `discussions', `discussions.comments'
or `discussions.comments.replies'. We know that it does so at the first
of these, but not whether it also does at the latter two. If it does,
that is a problem, which we would not be able to work around, because
(unlike `discussion') the singular variants `discussions.comment' and
`discussion.comments.reply' do not exist.
So stop limiting the number of replies to 20, and just hope that for
these edges, Github always returns all nodes, unless told otherwise.
To reduce the likelihood of making individual requests deemed to
expensive by Github, limit `discussions' to 30. This results in more
requests and ultimately is more expensive, but that's GraphQL for you.
Closes #843.1 parent d644f9e commit 5f7970f
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
| 98 | + | |
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
123 | | - | |
| 123 | + | |
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
| |||
0 commit comments