Skip to content

feat(utils): add scroll utilities #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maitamdev merged 1 commit into from
Mar 4, 2026
Merged

feat(utils): add scroll utilities #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/utils/scrollUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Scroll utility functions
export function scrollToElement(id: string, offset: number = 80): void {
const el = document.getElementById(id);
if (el) { const y = el.getBoundingClientRect().top + window.scrollY - offset; window.scrollTo({ top: y, behavior: 'smooth' }); }
}

export function lockScroll(): () => void {
const scrollY = window.scrollY;
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot Mar 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Unlocking scroll clears pre-existing body inline styles instead of restoring previous values, which can break layout state after closing a modal.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At src/utils/scrollUtils.ts, line 8:

<comment>Unlocking scroll clears pre-existing body inline styles instead of restoring previous values, which can break layout state after closing a modal.</comment>

<file context>
@@ -0,0 +1,14 @@
+}
+
+export function lockScroll(): () => void {
+  const scrollY = window.scrollY;
+  document.body.style.position = 'fixed';
+  document.body.style.top = '-' + scrollY + 'px';
</file context>
Fix with Cubic

document.body.style.position = 'fixed';
document.body.style.top = '-' + scrollY + 'px';
document.body.style.width = '100%';
return () => { document.body.style.position = ''; document.body.style.top = ''; document.body.style.width = ''; window.scrollTo(0, scrollY); };
}

Loading