Skip to content

feat(a11y): add focus manager#19

Merged
maitamdev merged 1 commit intomainfrom
feat/focus-manager
Mar 4, 2026
Merged

feat(a11y): add focus manager#19
maitamdev merged 1 commit intomainfrom
feat/focus-manager

Conversation

@maitamdev
Copy link
Copy Markdown
Owner

@maitamdev maitamdev commented Mar 4, 2026

Focus management for keyboard navigation and modal dialogs.


Summary by cubic

Added a lightweight focus manager for keyboard navigation and modal dialogs. Improves accessibility by restoring previous focus and cycling focus across focusable elements while skipping disabled controls.

  • New Features
    • getFocusableElements(container) returns focusable elements.
    • saveFocus() returns a function to restore the prior focused element.
    • moveFocus('next'|'prev') cycles focus with wrap-around.

Written for commit b920f19. Summary will update on new commits.

Co-authored-by: DHV Team <dhvteam@users.noreply.github.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dhv-guiding-light Building Building Preview, Comment Mar 4, 2026 7:20pm

@maitamdev maitamdev merged commit 4d7b11d into main Mar 4, 2026
1 of 3 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 4, 2026

Warning

Rate limit exceeded

@maitamdev has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 2 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 195b586d-9ccc-499b-9650-3ba66a9a05f7

📥 Commits

Reviewing files that changed from the base of the PR and between e651fcd and b920f19.

📒 Files selected for processing (1)
  • src/utils/focusManager.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/focus-manager

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/utils/focusManager.ts">

<violation number="1" location="src/utils/focusManager.ts:3">
P1: Malformed CSS selector for tabindex will cause `querySelectorAll` to fail at runtime.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@@ -0,0 +1,16 @@
// Focus management utilities
export function getFocusableElements(container: HTMLElement): HTMLElement[] {
const selectors = 'a[href], button:not([disabled]), input:not([disabled]), select:not([disabled]), textarea:not([disabled]), [tabindex]:not([tabindex=""-1""])';
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Malformed CSS selector for tabindex will cause querySelectorAll to fail at runtime.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/utils/focusManager.ts, line 3:

<comment>Malformed CSS selector for tabindex will cause `querySelectorAll` to fail at runtime.</comment>

<file context>
@@ -0,0 +1,16 @@
+// Focus management utilities
+export function getFocusableElements(container: HTMLElement): HTMLElement[] {
+  const selectors = 'a[href], button:not([disabled]), input:not([disabled]), select:not([disabled]), textarea:not([disabled]), [tabindex]:not([tabindex=""-1""])';
+  return Array.from(container.querySelectorAll(selectors));
+}
</file context>
Fix with Cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant