Merge pull request #841 from jmrenouard/fix-innodb-efficiency-suggestion

jmrenouard · web-flow · commit f2732bf75314 · 2025-08-28T18:57:25.000+02:00
Fix innodb efficiency suggestion
diff --git a/mysqltuner.pl b/mysqltuner.pl
@@ -6769,7 +6769,10 @@ sub mysql_innodb {
     }
 
     # InnoDB Read efficiency
-    if ( defined $mycalc{'pct_read_efficiency'}
+    if ( $mystat{'Innodb_buffer_pool_reads'} > $mystat{'Innodb_buffer_pool_read_requests'} ) {
+        infoprint "InnoDB Read buffer efficiency: metrics are not reliable (reads > read requests)";
+    }
+    elsif ( defined $mycalc{'pct_read_efficiency'}
         && $mycalc{'pct_read_efficiency'} < 90 )
     {
         badprint "InnoDB Read buffer efficiency: "
@@ -6791,7 +6794,10 @@ sub mysql_innodb {
     }
 
     # InnoDB Write efficiency
-    if ( defined $mycalc{'pct_write_efficiency'}
+    if ( $mystat{'Innodb_log_writes'} > $mystat{'Innodb_log_write_requests'} ) {
+        infoprint "InnoDB Write Log efficiency: metrics are not reliable (writes > write requests)";
+    }
+    elsif ( defined $mycalc{'pct_write_efficiency'}
         && $mycalc{'pct_write_efficiency'} < 90 )
     {
         badprint "InnoDB Write Log efficiency: "

Original file line number	Diff line number	Diff line change
`@@ -6769,7 +6769,10 @@ sub mysql_innodb {`
`6769`	`6769`	`}`
`6770`	`6770`
`6771`	`6771`	`# InnoDB Read efficiency`
`6772`		`- if ( defined $mycalc{'pct_read_efficiency'}`
	`6772`	`+ if ( $mystat{'Innodb_buffer_pool_reads'} > $mystat{'Innodb_buffer_pool_read_requests'} ) {`
	`6773`	`+ infoprint "InnoDB Read buffer efficiency: metrics are not reliable (reads > read requests)";`
	`6774`	`+ }`
	`6775`	`+ elsif ( defined $mycalc{'pct_read_efficiency'}`
`6773`	`6776`	`&& $mycalc{'pct_read_efficiency'} < 90 )`
`6774`	`6777`	`{`
`6775`	`6778`	`badprint "InnoDB Read buffer efficiency: "`
`@@ -6791,7 +6794,10 @@ sub mysql_innodb {`
`6791`	`6794`	`}`
`6792`	`6795`
`6793`	`6796`	`# InnoDB Write efficiency`
`6794`		`- if ( defined $mycalc{'pct_write_efficiency'}`
	`6797`	`+ if ( $mystat{'Innodb_log_writes'} > $mystat{'Innodb_log_write_requests'} ) {`
	`6798`	`+ infoprint "InnoDB Write Log efficiency: metrics are not reliable (writes > write requests)";`
	`6799`	`+ }`
	`6800`	`+ elsif ( defined $mycalc{'pct_write_efficiency'}`
`6795`	`6801`	`&& $mycalc{'pct_write_efficiency'} < 90 )`
`6796`	`6802`	`{`
`6797`	`6803`	`badprint "InnoDB Write Log efficiency: "`