test(rlsapi): update fixtures for chat completions API

Update test fixtures to mock the new chat.completions.create() API
instead of the removed get_temp_agent abstraction. Removed unused
AgentFixtures import.

Signed-off-by: Major Hayden <major@redhat.com>

Author: major

tests/unit/app/endpoints/test_rlsapi_v1.py

@@ -25,7 +25,6 @@
     RlsapiV1Terminal,
 )
 from models.rlsapi.responses import RlsapiV1InferResponse
-from tests.unit.conftest import AgentFixtures
 from tests.unit.utils.auth_helpers import mock_authorization_resolvers
 from utils.suid import check_suid
 
@@ -44,29 +43,31 @@ def mock_configuration_fixture(
 
 
 @pytest.fixture(name="mock_llm_response")
-def mock_llm_response_fixture(
-    mocker: MockerFixture, prepare_agent_mocks: AgentFixtures
-) -> None:
-    """Mock the LLM integration for successful responses."""
-    mock_client, mock_agent = prepare_agent_mocks
+def mock_llm_response_fixture(mocker: MockerFixture) -> None:
+    """Mock the LLM integration for successful responses via chat.completions."""
+    # Create mock message with content
+    mock_message = mocker.Mock()
+    mock_message.content = "This is a test LLM response."
 
-    # Create mock output message with content
-    mock_output_message = mocker.Mock()
-    mock_output_message.content = "This is a test LLM response."
+    # Create mock choice with message
+    mock_choice = mocker.Mock()
+    mock_choice.message = mock_message
 
-    # Create mock turn response
-    mock_turn = mocker.Mock()
-    mock_turn.output_message = mock_output_message
-    mock_turn.steps = []
+    # Create mock completion response with choices
+    mock_response = mocker.Mock()
+    mock_response.choices = [mock_choice]
 
-    # Use AsyncMock for async method
-    mock_agent.create_turn = mocker.AsyncMock(return_value=mock_turn)
+    # Create mock chat.completions.create() method
+    mock_completions = mocker.Mock()
+    mock_completions.create = mocker.AsyncMock(return_value=mock_response)
 
-    # Mock get_temp_agent to return our mock agent
-    mocker.patch(
-        "app.endpoints.rlsapi_v1.get_temp_agent",
-        return_value=(mock_agent, "test_session_id", None),
-    )
+    # Create mock chat object
+    mock_chat = mocker.Mock()
+    mock_chat.completions = mock_completions
+
+    # Create mock client
+    mock_client = mocker.Mock()
+    mock_client.chat = mock_chat
 
     # Mock the client holder
     mock_client_holder = mocker.Mock()
@@ -78,27 +79,20 @@ def mock_llm_response_fixture(
 
 
 @pytest.fixture(name="mock_empty_llm_response")
-def mock_empty_llm_response_fixture(
-    mocker: MockerFixture, prepare_agent_mocks: AgentFixtures
-) -> None:
-    """Mock the LLM integration for empty responses (output_message=None)."""
-    mock_client, mock_agent = prepare_agent_mocks
+def mock_empty_llm_response_fixture(mocker: MockerFixture) -> None:
+    """Mock chat.completions to return empty choices list."""
+    mock_response = mocker.Mock()
+    mock_response.choices = []
 
-    # Create mock turn response with no output
-    mock_turn = mocker.Mock()
-    mock_turn.output_message = None
-    mock_turn.steps = []
+    mock_completions = mocker.Mock()
+    mock_completions.create = mocker.AsyncMock(return_value=mock_response)
 
-    # Use AsyncMock for async method
-    mock_agent.create_turn = mocker.AsyncMock(return_value=mock_turn)
+    mock_chat = mocker.Mock()
+    mock_chat.completions = mock_completions
 
-    # Mock get_temp_agent to return our mock agent
-    mocker.patch(
-        "app.endpoints.rlsapi_v1.get_temp_agent",
-        return_value=(mock_agent, "test_session_id", None),
-    )
+    mock_client = mocker.Mock()
+    mock_client.chat = mock_chat
 
-    # Mock the client holder
     mock_client_holder = mocker.Mock()
     mock_client_holder.get_client.return_value = mock_client
     mocker.patch(
@@ -109,11 +103,20 @@ def mock_empty_llm_response_fixture(
 
 @pytest.fixture(name="mock_api_connection_error")
 def mock_api_connection_error_fixture(mocker: MockerFixture) -> None:
-    """Mock AsyncLlamaStackClientHolder to raise APIConnectionError."""
-    mock_client_holder = mocker.Mock()
-    mock_client_holder.get_client.side_effect = APIConnectionError(
-        request=mocker.Mock()
+    """Mock chat.completions.create() to raise APIConnectionError."""
+    mock_completions = mocker.Mock()
+    mock_completions.create = mocker.AsyncMock(
+        side_effect=APIConnectionError(request=mocker.Mock())
     )
+
+    mock_chat = mocker.Mock()
+    mock_chat.completions = mock_completions
+
+    mock_client = mocker.Mock()
+    mock_client.chat = mock_chat
+
+    mock_client_holder = mocker.Mock()
+    mock_client_holder.get_client.return_value = mock_client
     mocker.patch(
         "app.endpoints.rlsapi_v1.AsyncLlamaStackClientHolder",
         return_value=mock_client_holder,
@@ -212,6 +215,7 @@ async def test_infer_minimal_request(
 
     assert isinstance(response, RlsapiV1InferResponse)
     assert response.data.text == "This is a test LLM response."
+    assert response.data.request_id is not None
     assert check_suid(response.data.request_id)