Commit 12bdbab
doc(mtmd/qwen3vl): warn image_tile_mode zero-init selects batched, not the default
Addresses PR tetherto#175 review (tetherto#3): the shipped enum is 0=batched while the default mode
is sequential, so a zero-initialized clip_context_params/mtmd_context_params silently
selects the batched (unverified ne[3]) path instead of the intended default.
Renumbering to 0=sequential would be the clean fix, but the values are already released
as a string API ("0"/"1"/"2" in consumers), so renumbering would break existing callers.
Instead, document the trap prominently in clip.h and mtmd.h and point callers at
mtmd_context_params_default() (which sets sequential).1 parent ffb6ef4 commit 12bdbab
2 files changed
Lines changed: 15 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
49 | 56 | | |
50 | | - | |
51 | | - | |
| 57 | + | |
| 58 | + | |
52 | 59 | | |
53 | 60 | | |
54 | 61 | | |
| |||
65 | 72 | | |
66 | 73 | | |
67 | 74 | | |
68 | | - | |
| 75 | + | |
69 | 76 | | |
70 | 77 | | |
71 | 78 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
118 | 122 | | |
119 | 123 | | |
120 | 124 | | |
| |||
0 commit comments