Conversation
… improve layout structure and alignment.
…n not in wallet accounts
…s are connected or selected
…ite reloading on dev server, update non-hot-reload configuration to include background and sdk scripts.
…on-deploy-rows.tsx`.
…n`, and remove unused `useTheme`.
… result display logic.
…th new project version.
… `deepmerge` dependency.
…` with `action.collectionHash`.
…integrate `useFetchContractPackage` for improved contract package handling.
…e layout with overflow handling, and improve contract info display.
…ended timeouts, update Playwright version, and refine popup interaction flows.
…pendency to 1.6.4
…eOriginFavicon` with `origin` and `getFaviconUrlFromOrigin` for improved origin handling.
…tab-specific communication.
…rigin`-based methods with `origin`-specific selectors for improved origin handling and consistency.
…ssful sign The beforeunload listener on sign-transaction, sign-message, and decrypt-message pages calls handleCancel, which broadcasts a sign/decrypt response with cancelled: true. After a successful sign/decrypt the page closes its window, beforeunload fires, and a second response with the same requestId is broadcast. Guard each page with a responseSentRef so handleCancel returns early once any response (success or cancel) has been dispatched.
…request pages using `responseSentRef`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to fill in all the below sections.
Description
// Provide a useful description of this PR, aimed at helping reviewers and contributors
Linked tickets
WALLET-XXX
Checklist
Make sure this PR title follows semantic release conventions: https://semantic-release.gitbook.io/semantic-release/#commit-message-format
If the PR adds any new text to the UI, make sure they are localized
Include a screenshot or recording if implementing significant UI or user flow change
When this PR affects architecture changes wait for review from Dmytro before merging