Skip to content

feat: EIP-712 signature requests (WALLET-1251) #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Comp0te merged 22 commits into from
Jun 17, 2026
Merged

feat: EIP-712 signature requests (WALLET-1251) #1342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
663ebb2
build: bump casper-js-sdk to 5.0.12 and date-fns to v4 for EIP-712 core
ost-ptk Jun 10, 2026
7112f64
feat(sdk): add EIP-712 signTypedData types
ost-ptk Jun 10, 2026
aee1769
feat(sdk): add signTypedData request/response/error actions
ost-ptk Jun 10, 2026
e73a65e
feat(sdk): expose signTypedData provider method
ost-ptk Jun 10, 2026
b5a1a4f
feat(redux): store EIP-712 typed data by request id in vault slice
ost-ptk Jun 11, 2026
5fcf6cf
feat: add SignEip712 route and window app
ost-ptk Jun 11, 2026
a135e99
feat(background): handle signTypedData request and open EIP-712 window
ost-ptk Jun 11, 2026
a3e5a07
feat(services): add useFetchDataForEip712Request hook
ost-ptk Jun 11, 2026
9cfbae3
feat(ui): add EIP-712 display row mapper component
ost-ptk Jun 11, 2026
844d99b
feat(ui): add EIP-712 content with Domain and Message blocks
ost-ptk Jun 11, 2026
285ca92
feat(ui): add SignEip712Page with fetch, sign and cancel
ost-ptk Jun 11, 2026
0f2b735
feat: wire SignEip712Page route
ost-ptk Jun 11, 2026
c3f7d9d
fix: import casper-js-sdk types from package root for v5.0.12
ost-ptk Jun 11, 2026
df33dc3
fix(ui): align EIP-712 rows and reuse network display with icon
ost-ptk Jun 11, 2026
93d09e1
chore: update casper-wallet-core dependency to latest commit
ost-ptk Jun 11, 2026
f2db801
fix(sdk): register signTypedData response/error in content message proxy
ost-ptk Jun 11, 2026
424872a
chore: bump casper-wallet-core to latest commit and update dependencies
ost-ptk Jun 12, 2026
e600122
feat: reject EIP-712 signing for Ledger accounts (WALLET-1251)
ost-ptk Jun 12, 2026
272afe0
Merge branch 'develop' into WALLET-1251-cw-eip-712-signature-requests
ost-ptk Jun 16, 2026
78a3380
fix: address EIP-712 signature request review feedback
ost-ptk Jun 16, 2026
4999d2a
chore: update casper-wallet-core dependency to latest commit
ost-ptk Jun 16, 2026
6ec4d0e
test(e2e): update failed transfer error heading for casper-js-sdk 5.0.12
ost-ptk Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e-tests/popup/transfers/casper-native-transfer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ popup.describe('Popup UI: Casper Native Transfer', () => {

await popupExpect(
popupPage.getByRole('heading', {
name: 'failed to send http request, details: Code: 500, err: Internal Server Error'
name: 'Internal Server Error'
})
).toBeVisible();
await popupExpect(
Expand Down
2 changes: 1 addition & 1 deletion e2e-tests/popup/transfers/erc-20-transfer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ popup.describe('Popup UI: ERC-20 transfer', () => {

await popupExpect(
popupPage.getByRole('heading', {
name: 'failed to send http request, details: Code: 500, err: Internal Server Error'
name: 'Internal Server Error'
})
).toBeVisible();
await popupExpect(
Expand Down
216 changes: 115 additions & 101 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@
"@zondax/ledger-casper": "^2.6.3",
"base64-loader": "1.0.0",
"big.js": "^6.2.1",
"casper-js-sdk": "5.0.10",
"casper-wallet-core": "git+ssh://git@github.com:make-software/casper-wallet-core.git#v1.3.0",
"date-fns": "^2.30.0",
"casper-js-sdk": "5.0.12",
"casper-wallet-core": "git+ssh://git@github.com:make-software/casper-wallet-core.git#442723023778ee0bbfce3ca886015d1372a883e2",
"date-fns": "^4.1.0",
"dotenv-webpack": "^8.1.0",
"i18next": "^23.11.0",
"i18next-browser-languagedetector": "^7.2.1",
Expand Down
Loading
Loading