build(deps): DEP-7 — redux 5 + react-redux 9 + reselect 5 + redux-saga 1.5 (WALLET-1333)#1383
Merged
Comp0te merged 2 commits intoJul 2, 2026
Conversation
…a 1.5 (WALLET-1333) Bump redux 4.2.1 -> 5.0.1, react-redux 8.1.3 -> 9.3.0, reselect 4.1.7 -> 5.2.0, and redux-saga 1.2.3 -> 1.5.0. Fix a dead deep-import (`react-redux/es/exports`) left over from react-redux 8, which no longer resolves under react-redux 9's ESM `exports` map. Wrap four previously-unmemoized selectors (selectVaultAccountsPublicKeys, selectVaultAccountsExceptLedgersAccounts, selectAllContactsNames, selectAllContactsPublicKeys) in createSelector, and split selectIsAccountConnected's tuple-returning input selector into two scalar input selectors — both were returning a new reference on every call, which reselect 5's new default inputStabilityCheck/react-redux 9's stabilityCheck now surface as dev-mode warnings.
9 tasks
…ux-9-reselect-5-redux-saga-1-5
Comp0te
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
redux4.2.1 → 5.0.1,react-redux8.1.3 → 9.3.0,reselect4.1.7 → 5.2.0,redux-saga1.2.3 → 1.5.0.react-redux/es/exports→react-redux) insrc/apps/signature-request/index.tsx, left over from react-redux 8 — the deep path no longer resolves under react-redux 9's ESMexportsmap.selectVaultAccountsPublicKeys,selectVaultAccountsExceptLedgersAccounts,selectAllContactsNames,selectAllContactsPublicKeys) increateSelector, and splitselectIsAccountConnected's tuple-returning input selector into two scalar input selectors. Both were returning a new reference on every call — reselect 5's new defaultinputStabilityCheck/ react-redux 9'sstabilityChecknow surface this as dev-mode console warnings; the underlying re-render cost existed before this bump too.No
AnyAction→UnknownActionrename, nocreateStore→configureStoremigration, and notypesafe-actionsremoval — all out of scope for this ticket.Jira: https://make-software.atlassian.net/browse/WALLET-1333
Test plan
npm run tsc— clean, no errors (no cast needed inroot-reducer.ts'scombineReducers)npm run lint— 0 errors (175 pre-existing unrelated warnings)npm run format:check— cleannpm test— 32/32 passingnpm run build:chrome/build:firefox— succeed@ts-ignorelines insrc/background/redux/index.tsare still required under redux 5 (removed them experimentally,tscimmediately errored, reverted)useSelectorafter unlocking, dispatching a mutation propagates throughpopupStateUpdatedto the UI replica, signature-request app (sign/delegate/undelegate/redelegate) works correctly