ci: run CI Check on release/** branches#1385
Merged
Merged
Conversation
PRs targeting release branches (e.g. the DEP-* dependency-bump series into release/2.6.0) currently get no automated Linux gate, since CI Check only triggers on master/develop. This lets install- or platform-specific regressions — such as a package-lock.json that resolves on macOS but drops Linux native bindings — pass review and only surface when the release branch later merges into develop. Extend the fast CI Check workflow (format/lint/tsc/test) to also run on push and pull_request for release/** branches. The heavier e2e Playwright workflows are intentionally left on their existing master/develop schedule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the CI Check workflow (format/lint/tsc/test) to also run on
pushandpull_requestevents forrelease/**branches.Why
CI Check currently triggers only for
masteranddevelop, so PRs targeting release branches — including the DEP-* dependency-bump series merging intorelease/2.6.0— get no automated Linux gate. This lets install- or platform-specific regressions pass review and only surface when the release branch later merges intodevelop.Concretely: a regenerated
package-lock.jsoncan resolve correctly on the author's macOS machine while dropping the Linux native-binding entries (e.g.@unrs/resolver-binding-linux-x64-gnu, used by ESLint's TS import resolver and jest-resolve, plus itswasm32-wasifallback). Onubuntu-latestwithnpm ci, lint/test then fail — but with no CI on release PRs, nothing catches it.What
Add
release/**to thepushandpull_requestbranch filters of the fast CI Check workflow, giving every release-targeted PR the same Linuxnpm ci+ format/lint/tsc/test gate asdevelop.The heavier e2e Playwright workflows (
e2e-popup-tests,e2e-onboarding-tests) are intentionally left on their existingmaster/developschedule, to avoid running 60-minute container jobs on every dependency PR.