Fix multiselect dropdown and few other improvements#17
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes several issues with the multiselect dropdown component and makes other improvements including font weight additions, icon path corrections, and story adjustments.
- Removes duplicate
MultiSelectDropdowncomponent from the main dropdown file - Adds new
700weight for JetBrains Mono font and updates header text font weight logic - Replaces hardcoded icon paths with proper icon imports across multiple components
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/theme-config.ts | Adds documentation comments for existing font weights |
| src/lib/components/paginated-table/table-error.tsx | Replaces hardcoded icon path with SearchIcon import |
| src/lib/components/paginated-table/paginated-table.stories.tsx | Adds error control to story argTypes |
| src/lib/components/navigation/navigation-banner/navigation-banner.stories.tsx | Replaces hardcoded icon paths with proper icon imports |
| src/lib/components/input/input.tsx | Replaces hardcoded error icon path with ErrorIcon import |
| src/lib/components/header-text/header-text.tsx | Updates monotype font weight logic and fixes trailing commas |
| src/lib/components/dropdown/dropdown.tsx | Removes entire MultiSelectDropdown component and related code |
| src/04-Typography.mdx | Adds new Typeset example for bold mono font |
| package.json | Bumps version from 2.0.3 to 2.0.4 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| isFixedDropdown?: boolean; | ||
| } | ||
|
|
||
| export function MultiSelectDropdown(props: MultiSelectDropdownProps) { |
There was a problem hiding this comment.
please dont remove it, it is used on other projects
There was a problem hiding this comment.
hm.. that is not good :( ok i will put it back
There was a problem hiding this comment.
thanks @victoriari for noticing that. I found a few silly issues in our library with that dropdowns
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…st story Signed-off-by: Evgeniy Bilov <eugenebelov@users.noreply.github.com>
Signed-off-by: Evgeniy Bilov <eugenebelov@users.noreply.github.com>
eugenebelov
force-pushed
the
bugfix/multyselect-dropdown-export
branch
from
7d0a9cd to
db28936
Compare
fix dropdown import; add new weight for mono font; fix icons and adjust story
Summary
700for Jetbrains Mono fontType of Change
Component(s) Affected
ComponentNameDropdown,HeaderText,Input,Theme ConfigComponentNameChanges Made
Testing
Storybook
Breaking Changes
Screenshots/Videos
TODO
Checklist