fix(headlamp): set config.oidc.useCookie=true#20
Merged
Conversation
Headlamp's default OIDC popup uses window.opener postMessage to deliver the auth result to the parent. State drops on cross-origin redirects (Headlamp -> Dex -> GitHub -> Dex -> Headlamp), so the popup closes without the parent ever seeing the token, and the user gets re-prompted. Switching to useCookie stores the auth session server-side, keyed off a cookie set during the callback. The parent picks it up via a regular fetch, no postMessage needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Headlamp's default OIDC popup flow uses `window.opener.postMessage` to deliver the auth result back to the parent window. State drops on cross-origin redirects (Headlamp → Dex → GitHub → Dex → Headlamp), so the popup closes without the parent ever seeing the token, and the user gets re-prompted indefinitely.
`config.oidc.useCookie: true` flips the chart to add the `-oidc-use-cookie` arg, which stores the auth session server-side, keyed off a cookie set during the callback. The parent picks it up via a normal fetch, no postMessage needed.
Test plan
🤖 Generated with Claude Code