feat(rbac): bind makeitworkcloud:admins GitHub team to cluster-admin#22
Merged
feat(rbac): bind makeitworkcloud:admins GitHub team to cluster-admin#22
Conversation
Pairs with the k3s apiserver --oidc-* flags (tfroot-libvirt). When a user authenticates to Headlamp (or any OIDC-aware kubectl) via Dex, their ID token carries `groups: ["makeitworkcloud:admins"]`. This ClusterRoleBinding maps that group to cluster-admin so the apiserver authorizes their requests without per-user RoleBindings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Headlamp authenticates a user via Dex, the resulting ID token is forwarded to kube-apiserver. With the apiserver's `--oidc-issuer-url` / `--oidc-client-id=headlamp` / `--oidc-username-claim=email` / `--oidc-groups-claim=groups` flags (added to k3s cloud-init in the matching tfroot-libvirt PR), the apiserver validates the token and surfaces the user as e.g. `steven@makeitwork.cloud` with groups like `makeitworkcloud:admins`. Without an RBAC binding the user is recognized but not authorized → 401 from the apiserver, which Headlamp interprets as a failed login and re-prompts.
This adds a single ClusterRoleBinding mapping the GitHub team `makeitworkcloud:admins` to cluster-admin. Anyone in that team gets full kubectl/Headlamp access; non-members get the standard denied response.
Pairs with
Test plan
🤖 Generated with Claude Code