fix(arc-tf): silence listener-resource drift via SSA + ignoreDifferences#26
Merged
fix(arc-tf): silence listener-resource drift via SSA + ignoreDifferences#26
Conversation
The gha-runner-scale-set controller dynamically creates the listener AutoscalingListener and a paired Role/RoleBinding (named `<release>-<hash>-listener`) at runtime, and rotates hash annotations on them on every reconcile. None are in the chart's rendered output, so ArgoCD reports them OutOfSync. Add ServerSideApply=true so ArgoCD respects field-manager separation between itself and the controller, and extend ignoreDifferences to cover annotation churn on the Role/RoleBinding kinds the controller also touches.
xnoto
added a commit
that referenced
this pull request
Apr 30, 2026
## Summary Revert the additions from #26 — they didn't actually resolve the OutOfSync state, which structurally needs a cluster-wide \`resourceTrackingMethod\` change to fix and is functionally cosmetic. Keep only the AutoscalingRunnerSet \`ignoreDifferences\` entry that prevents selfHeal from thrashing on controller-driven annotation churn. ### Removed (from #26) - \`ServerSideApply=true\` syncOption - \`Role\` / \`RoleBinding\` \`ignoreDifferences\` entries ### Removed (cleanup, was originally added in #25) - \`AutoscalingListener\` \`ignoreDifferences\` entry — the chart doesn't render that kind at all, so there's nothing for ArgoCD to drift from ### Kept - \`AutoscalingRunnerSet\` \`ignoreDifferences\` for \`/metadata/annotations\` and \`/spec/template\` (chart-rendered, does see real drift) - \`RespectIgnoreDifferences=true\` syncOption ## Comment in the manifest now documents the cosmetic OutOfSync as accepted. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`arc-tf` Application has been showing OutOfSync because the gha-runner-scale-set controller dynamically creates an `AutoscalingListener` plus a paired `Role` / `RoleBinding` (named `--listener`) at runtime — none of which are in the chart's rendered output — and rotates hash annotations on them on every reconcile.
Two parts to the fix:
Test plan
🤖 Generated with Claude Code