fix: reorder disks to match libvirt return order

Place cdrom disk last in concat since libvirt returns virtio disks
before sata/ide devices. This prevents 'Provider produced inconsistent
result after apply' errors with dmacvicar/libvirt provider 0.9.x.

Also expand lifecycle ignore_changes to specifically target disks and
graphics attributes that exhibit ordering drift.

Author: xnoto

main.tf

@@ -60,6 +60,9 @@ resource "libvirt_domain" "vm" {
   }
 
   devices = {
+    # Disk ordering: boot disk, extra volumes, then cdrom LAST
+    # libvirt returns disks sorted by bus type (virtio before sata/ide)
+    # so we must define them in that order to avoid provider inconsistency errors
     disks = concat(
       [
         {
@@ -73,33 +76,35 @@ resource "libvirt_domain" "vm" {
             dev = "vda"
             bus = "virtio"
           }
-        },
-        {
+        }
+      ],
+      [
+        for idx, vol in libvirt_volume.extra : {
           source = {
             volume = {
               pool   = var.storage_pool
-              volume = libvirt_volume.cloudinit.name
+              volume = vol.name
             }
           }
           target = {
-            dev = "hda"
-            bus = "sata"
+            dev = "vd${substr("bcdefghij", idx, 1)}"
+            bus = "virtio"
           }
-          device = "cdrom"
         }
       ],
       [
-        for idx, vol in libvirt_volume.extra : {
+        {
           source = {
             volume = {
               pool   = var.storage_pool
-              volume = vol.name
+              volume = libvirt_volume.cloudinit.name
             }
           }
           target = {
-            dev = "vd${substr("cdefghij", idx, 1)}"
-            bus = "virtio"
+            dev = "sda"
+            bus = "sata"
           }
+          device = "cdrom"
         }
       ]
     )
@@ -145,7 +150,14 @@ resource "libvirt_domain" "vm" {
   }
 
   lifecycle {
-    ignore_changes = [devices]
+    # Ignore device ordering changes - libvirt provider 0.9.x has a bug where
+    # it returns disks in a different order than specified, causing
+    # "Provider produced inconsistent result after apply" errors.
+    # Also ignore graphics changes due to similar provider bugs.
+    ignore_changes = [
+      devices.disks,
+      devices.graphics,
+    ]
   }
 }