feat: delete unconfirmed users fixes

Author: pajgo

doc/rfcs/inactive_users_cleanup.md

@@ -36,6 +36,8 @@ For correct code deduplication in redis scripts, we need to provide some templat
 `deleteInactivated.lua`
 Delete process requires a lot of data resolved before execution and all database actions must be executed in one shot, to save database consistence. Exports `deleteInactivated` command into namespace and wrapped by `utils/inactive/deleteUsers.js`.
 
+For Redis compat 5.0 > ver < 3.2 only db commands passed to replica servers. Lua script behaviour changed in Redis 5.0: replicates script as effect, older versions pass script between redis insances.
+
 When script started:
 1. It extracts from `inactive-user` list of `userId` with score range '-inf' to 'currentimestamp - ttl'.
 2. Removes all user data including aliases, emails,  metadata, tokens, SSO accounts, throttles and cleans all bound indicies

scripts/deleteInactivated.lua

@@ -148,6 +148,7 @@ local function cleanInactiveUsers(idList)
 end
 
 -- Command body
+redis.replicate_commands();
 local inactiveUsers = getInactiveUsers();
 
 for k,v in pairs(inactiveUsers) do

src/actions/activate.js

@@ -195,8 +195,8 @@ function activateAction({ params }) {
   };
 
   return Promise
-    .resolve(['users:cleanup'])
-    .spread(this.hook.bind(this))
+    .bind(this, ['users:cleanup'])
+    .spread(this.hook)
     .bind(context)
     .then(verifyRequest)
     .bind(this)

src/actions/register.js

@@ -349,8 +349,8 @@ module.exports = async function registerUser({ params }) {
     .disposer(lockDisposer);
 
   return Promise
-    .resolve(['users:cleanup'])
-    .spread(service.hook.bind(service))
+    .bind(this, ['users:cleanup'])
+    .spread(service.hook)
     .then(() => {
       return Promise.using({ service, params }, acquireLock, performRegistration);
     })