feat: delete inactivated users

* updateMetadata no lodash
* doc addons
* cleanUsers supperess error parameter

Author: pajgo

rfcs/inactive_users_cleanup.md

@@ -31,7 +31,19 @@ Record contains `userId` and `current timestamp`.
 ## Activation process
 When the user succeeds activation `userId`,the entry deleted from `inactive-users`.
 
-## `users:cleanup` hook
+## `users:cleanup` hook `cleanUsers(suppress?)`
+`suppress` parameter defines function error behavior. If parameter set, the function throws errors,
+otherwise, function calls `log.error` with `error.message` as message.
+
+Other option, is to define new config parameter as object and move `config.deleteInactiveAccounts` into it:
+```javascript
+const conf = {
+  deleteInactiveUsers: {
+    ttl: seconds, // replaces deleteInactiveAccounts
+    suppressErrors: true || false,
+  },
+}
+```
 Calls `deleteInactivatedUsers` script with TTL parameter from `service.config.deleteInactiveAccounts`.
 
 ## Redis Delete Inactive User Script

src/utils/inactiveUsers/index.js

@@ -22,15 +22,24 @@ function removeFromInactiveUsers(redis, userId) {
   redis.zrem(USERS_INACTIVATED, userId);
 }
 
-async function cleanUsers() {
+/**
+ * Deletes users that didn't pass activation
+ * @param suppressError boolean throw or suppress error
+ * @returns {Promise<number>}
+ */
+async function cleanUsers(suppressError = true) {
   const { redis } = this;
   const { deleteInactiveAccounts } = this.config;
   let deletedUsers = 0;
 
   try {
     deletedUsers = await deleteInactiveUsers(redis, deleteInactiveAccounts);
   } catch (e) {
-    this.log.error(e);
+    if (suppressError) {
+      this.log.error({ error: e }, e.message);
+    } else {
+      throw e;
+    }
   }
 
   return deletedUsers;

src/utils/updateMetadata.js

@@ -1,7 +1,6 @@
 /* eslint-disable no-mixed-operators */
 const Promise = require('bluebird');
 const is = require('is');
-const ld = require('lodash');
 const { HttpStatusError } = require('common-errors');
 const mapValues = require('lodash/mapValues');
 const redisKey = require('../utils/key.js');
@@ -22,13 +21,18 @@ function callUpdateMetadataScript(redis, userId, ops) {
 // Stabilizes Lua script response
 function mapUpdateResponse(jsonStr) {
   const decodedData = JSONParse(jsonStr);
-  const result = ld.map(decodedData, (audienceProcessResult) => {
-    return ld.mapValues(audienceProcessResult, (ops) => {
-      if (ops.length === undefined) {
-        return ops;
+  const result = [];
+
+  decodedData.forEach((metaResult) => {
+    const opResult = {};
+    for (const [key, ops] of Object.entries(metaResult)) {
+      if (ops.length !== undefined && ops.length === 1) {
+        [opResult[key]] = ops;
+      } else {
+        opResult[key] = ops;
       }
-      return ops.length > 1 ? ops : ops[0];
-    });
+    }
+    result.push(opResult);
   });
 
   return result.length > 1 ? result : result[0];

test/suites/deleteInactivatedUsers.js

@@ -44,6 +44,35 @@ describe('#inactive user', function registerSuite() {
     return simpleDispatcher(this.users.router)('users.register', { ...regUserNoAlias });
   });
 
+  describe('throw suppress error', function test() {
+    const lua = 'return { foo bar }';
+
+    beforeEach(function pretest() {
+      const { redis } = this.users;
+      redis.defineCommand('deleteInactivatedUsers', { lua });
+    });
+
+    it('throws error', async function subtest() {
+      let err;
+      try {
+        await cleanUsers.call(this.users, false);
+      } catch (e) {
+        err = e;
+      }
+      expect(err).to.be.an('error');
+    });
+
+    it('suppresses error', async function subtest() {
+      let err;
+      try {
+        await cleanUsers.call(this.users);
+      } catch (e) {
+        err = e;
+      }
+      expect(err).to.be.an('undefined');
+    });
+  });
+
   it('deletes inactive user', function test() {
     return delay(() => {
       return cleanUsers.call(this.users)