fix: potential error points

aaryan610 · aaryan610 · commit 53aae45699f0 · 2025-10-29T14:54:01.000+05:30
diff --git a/apps/web/ce/components/command-palette/modals/index.ts b/apps/web/ce/components/command-palette/modals/index.ts
diff --git a/apps/web/ce/components/command-palette/modals/work-item-level.tsx b/apps/web/ce/components/command-palette/modals/work-item-level.tsx
@@ -15,11 +15,11 @@ import { useUser } from "@/hooks/store/user";
 import { useAppRouter } from "@/hooks/use-app-router";
 import { useIssuesActions } from "@/hooks/use-issues-actions";
 
-export type TIssueLevelModalsProps = {
+export type TWorkItemLevelModalsProps = {
   workItemIdentifier: string | undefined;
 };
 
-export const IssueLevelModals: FC<TIssueLevelModalsProps> = observer((props) => {
+export const WorkItemLevelModals: FC<TWorkItemLevelModalsProps> = observer((props) => {
   const { workItemIdentifier } = props;
   // router
   const { workspaceSlug, cycleId, moduleId } = useParams();
diff --git a/apps/web/core/components/power-k/config/help-commands.ts b/apps/web/core/components/power-k/config/help-commands.ts
@@ -35,7 +35,7 @@ export const usePowerKHelpCommands = (): TPowerKCommandConfig[] => {
       i18n_title: "power_k.help_actions.open_plane_documentation",
       icon: FileText,
       action: () => {
-        window.open("https://docs.plane.so/", "_blank");
+        window.open("https://docs.plane.so/", "_blank", "noopener,noreferrer");
       },
       isEnabled: () => true,
       isVisible: () => true,
@@ -48,7 +48,7 @@ export const usePowerKHelpCommands = (): TPowerKCommandConfig[] => {
       i18n_title: "power_k.help_actions.join_discord",
       icon: DiscordIcon,
       action: () => {
-        window.open("https://discord.com/invite/A92xrEGCge", "_blank");
+        window.open("https://discord.com/invite/A92xrEGCge", "_blank", "noopener,noreferrer");
       },
       isEnabled: () => true,
       isVisible: () => true,
@@ -61,7 +61,7 @@ export const usePowerKHelpCommands = (): TPowerKCommandConfig[] => {
       i18n_title: "power_k.help_actions.report_bug",
       icon: GithubIcon,
       action: () => {
-        window.open("https://github.com/makeplane/plane/issues/new/choose", "_blank");
+        window.open("https://github.com/makeplane/plane/issues/new/choose", "_blank", "noopener,noreferrer");
       },
       isEnabled: () => true,
       isVisible: () => true,
diff --git a/apps/web/core/components/power-k/config/preferences-commands.ts b/apps/web/core/components/power-k/config/preferences-commands.ts
@@ -2,6 +2,7 @@ import { useCallback } from "react";
 import { useTheme } from "next-themes";
 import { Calendar, Earth, Languages, Palette } from "lucide-react";
 // plane imports
+import { useTranslation } from "@plane/i18n";
 import { setToast, TOAST_TYPE } from "@plane/propel/toast";
 import type { EStartOfTheWeek, TUserProfile } from "@plane/types";
 // components
@@ -17,17 +18,29 @@ export const usePowerKPreferencesCommands = (): TPowerKCommandConfig[] => {
   const { setTheme } = useTheme();
   const { updateCurrentUser } = useUser();
   const { updateUserProfile, updateUserTheme } = useUserProfile();
+  // translation
+  const { t } = useTranslation();
 
   const handleUpdateTheme = useCallback(
     async (newTheme: string) => {
       setTheme(newTheme);
-      return updateUserTheme({ theme: newTheme }).catch(() => {
-        setToast({
-          type: TOAST_TYPE.ERROR,
-          title: "Failed to save user theme settings!",
+      return updateUserTheme({ theme: newTheme })
+        .then(() => {
+          setToast({
+            type: TOAST_TYPE.SUCCESS,
+            title: t("toast.success"),
+            message: t("power_k.preferences_actions.toast.theme.success"),
+          });
+        })
+        .catch(() => {
+          setToast({
+            type: TOAST_TYPE.ERROR,
+            title: t("toast.error"),
+            message: t("power_k.preferences_actions.toast.theme.error"),
+          });
         });
-      });
     },
+    // eslint-disable-next-line react-hooks/exhaustive-deps
     [setTheme, updateUserTheme]
   );
 
@@ -36,19 +49,20 @@ export const usePowerKPreferencesCommands = (): TPowerKCommandConfig[] => {
       updateCurrentUser({ user_timezone: value })
         .then(() => {
           setToast({
-            title: "Success!",
-            message: "Timezone updated successfully",
             type: TOAST_TYPE.SUCCESS,
+            title: t("toast.success"),
+            message: t("power_k.preferences_actions.toast.timezone.success"),
           });
         })
         .catch(() => {
           setToast({
-            title: "Error!",
-            message: "Failed to update timezone",
             type: TOAST_TYPE.ERROR,
+            title: t("toast.error"),
+            message: t("power_k.preferences_actions.toast.timezone.error"),
           });
         });
     },
+    // eslint-disable-next-line react-hooks/exhaustive-deps
     [updateCurrentUser]
   );
 
@@ -57,19 +71,20 @@ export const usePowerKPreferencesCommands = (): TPowerKCommandConfig[] => {
       updateUserProfile(payload)
         .then(() => {
           setToast({
-            title: "Success!",
-            message: "Language updated successfully",
             type: TOAST_TYPE.SUCCESS,
+            title: t("toast.success"),
+            message: t("power_k.preferences_actions.toast.generic.success"),
           });
         })
         .catch(() => {
           setToast({
-            title: "Error!",
-            message: "Failed to update language",
             type: TOAST_TYPE.ERROR,
+            title: t("toast.error"),
+            message: t("power_k.preferences_actions.toast.generic.error"),
           });
         });
     },
+    // eslint-disable-next-line react-hooks/exhaustive-deps
     [updateUserProfile]
   );
 
diff --git a/apps/web/core/components/power-k/projects-app-provider.tsx b/apps/web/core/components/power-k/projects-app-provider.tsx
@@ -9,8 +9,8 @@ import { usePowerK } from "@/hooks/store/use-power-k";
 import { useUser } from "@/hooks/store/user";
 import { useAppRouter } from "@/hooks/use-app-router";
 // plane web imports
-import { IssueLevelModals } from "@/plane-web/components/command-palette/modals/issue-level";
 import { ProjectLevelModals } from "@/plane-web/components/command-palette/modals/project-level";
+import { WorkItemLevelModals } from "@/plane-web/components/command-palette/modals/work-item-level";
 import { WorkspaceLevelModals } from "@/plane-web/components/command-palette/modals/workspace-level";
 // local imports
 import { useProjectsAppPowerKCommands } from "./config/commands";
@@ -79,7 +79,7 @@ export const ProjectsAppPowerKProvider = observer(() => {
       {workspaceSlug && projectId && (
         <ProjectLevelModals workspaceSlug={workspaceSlug.toString()} projectId={projectId.toString()} />
       )}
-      <IssueLevelModals workItemIdentifier={workItemIdentifier?.toString()} />
+      <WorkItemLevelModals workItemIdentifier={workItemIdentifier?.toString()} />
       <ProjectsAppPowerKModalWrapper
         commandsListComponent={ProjectsAppPowerKCommandsList}
         context={context}
diff --git a/apps/web/core/components/power-k/ui/modal/search-menu.tsx b/apps/web/core/components/power-k/ui/modal/search-menu.tsx
@@ -57,6 +57,10 @@ export const PowerKModalSearchMenu: React.FC<Props> = (props) => {
           );
           setResultsCount(count);
         })
+        .catch(() => {
+          setResults(WORKSPACE_DEFAULT_SEARCH_RESULT);
+          setResultsCount(0);
+        })
         .finally(() => setIsSearching(false));
     } else {
       setResults(WORKSPACE_DEFAULT_SEARCH_RESULT);
diff --git a/apps/web/core/components/power-k/ui/modal/wrapper.tsx b/apps/web/core/components/power-k/ui/modal/wrapper.tsx
diff --git a/apps/web/core/components/power-k/ui/pages/context-based/work-item/commands.ts b/apps/web/core/components/power-k/ui/pages/context-based/work-item/commands.ts
@@ -61,7 +61,7 @@ export const usePowerKWorkItemContextBasedCommands = (): TPowerKCommandConfig[]
   const entityDetails = entityId ? getIssueById(entityId) : null;
   const isEpic = !!entityDetails?.is_epic;
   const projectDetails = entityDetails?.project_id ? getProjectById(entityDetails?.project_id) : undefined;
-  const isCurrentUserAssigned = entityDetails?.assignee_ids.includes(currentUser?.id ?? "");
+  const isCurrentUserAssigned = !!entityDetails?.assignee_ids?.includes(currentUser?.id ?? "");
   const isEstimateEnabled = entityDetails?.project_id
     ? areEstimateEnabledByProjectId(entityDetails?.project_id)
     : false;
@@ -99,7 +99,7 @@ export const usePowerKWorkItemContextBasedCommands = (): TPowerKCommandConfig[]
     (assigneeId: string) => {
       if (!entityDetails) return;
 
-      const updatedAssignees = entityDetails.assignee_ids ?? [];
+      const updatedAssignees = [...(entityDetails.assignee_ids ?? [])];
       if (updatedAssignees.includes(assigneeId)) updatedAssignees.splice(updatedAssignees.indexOf(assigneeId), 1);
       else updatedAssignees.push(assigneeId);
 
@@ -370,7 +370,7 @@ export const usePowerKWorkItemContextBasedCommands = (): TPowerKCommandConfig[]
       onSelect: (data) => {
         const labelId = (data as IIssueLabel)?.id;
         if (!workspaceSlug || !entityDetails || !entityDetails.project_id) return;
-        const updatedLabels = entityDetails.label_ids ?? [];
+        const updatedLabels = [...(entityDetails.label_ids ?? [])];
         if (updatedLabels.includes(labelId)) updatedLabels.splice(updatedLabels.indexOf(labelId), 1);
         else updatedLabels.push(labelId);
         handleUpdateEntity({
diff --git a/apps/web/core/components/power-k/ui/pages/work-item-selection-page.tsx b/apps/web/core/components/power-k/ui/pages/work-item-selection-page.tsx
@@ -29,7 +29,7 @@ type Props = {
   isWorkspaceLevel?: boolean;
 };
 
-export const IssueSelectionPage: React.FC<Props> = (props) => {
+export const WorkItemSelectionPage: React.FC<Props> = (props) => {
   const {
     workspaceSlug,
     projectId,
diff --git a/packages/i18n/src/locales/en/translations.ts b/packages/i18n/src/locales/en/translations.ts
@@ -2591,6 +2591,20 @@ export default {
       update_timezone: "Change timezone",
       update_start_of_week: "Change first day of week",
       update_language: "Change interface language",
+      toast: {
+        theme: {
+          success: "Theme updated successfully.",
+          error: "Failed to update theme. Please try again.",
+        },
+        timezone: {
+          success: "Timezone updated successfully.",
+          error: "Failed to update timezone. Please try again.",
+        },
+        generic: {
+          success: "Preferences updated successfully.",
+          error: "Failed to update preferences. Please try again.",
+        },
+      },
     },
     help_actions: {
       open_keyboard_shortcuts: "Open keyboard shortcuts",
