[WEB-6813] fix: module not associated when accepting intake work items

[anmolsinghbhatia]

Description

• Fixes a bug where selecting a module in the intake acceptance modal
  had no effect — the module was never associated with the work item.
• Root cause: the inline module guard data.module_ids && payload.module_ids
  required both to be truthy. Intake items always have null module_ids
  (no modules yet), so the entire block was skipped.
• Code refactoring

Type of Change

• Bug fix
• Code refactoring

Test Scenarios

• Accept intake item → select a module → verify module is associated
• Accept intake item → no module selected → verify no errors
• Accept intake item → select a cycle → verify cycle is associated
• Accept intake item → select both module and cycle → verify both associated
• Accept intake item → select multiple modules → verify all associated
• Edit existing work item → change module → verify add/remove works
• Edit existing work item → remove module → verify removal works
• Edit existing work item → change cycle → verify cycle switch works
• Edit existing work item → remove cycle → verify removal works
• Accept intake item with labels/assignees already set → verify preserved

Summary by CodeRabbit

• Performance

  • Reduced unnecessary backend calls when changing issue cycles or modules, improving update responsiveness.

• Refactor

  • Reorganized issue update logic into clearer, targeted handlers for cycle and module changes, simplifying the update flow and making property updates more reliable.

[makeplane]

Linked to Plane Work Item(s)

• [WEB-6813] Module Not Displayed in Work Item Detail Page After Adding During Intake Acceptance

This comment was auto-generated by Plane

[coderabbitai]

📝 Walkthrough

Walkthrough

Extracted cycle and module mutation logic from the issue modal into two helper functions, handleCycleChange and handleModuleChange; added deep equality checks via isEqual; handleUpdateIssue now invokes those helpers sequentially before continuing with property-value updates.

Changes

Cohort / File(s)	Summary
Cycle & Module Update Refactoring apps/web/core/components/issues/issue-modal/base.tsx	Added handleCycleChange() and handleModuleChange() to centralize cycle/module mutation logic with guard clauses and error logging. Updated lodash import to include isEqual. Replaced inline add/remove module and cycle code in handleUpdateIssue() with sequential calls to the new helpers (no Promise.all).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰
I hopped through code with careful paws,
Split logic into tidy laws.
Cycles change and modules too,
Clean helpers now know what to do.
A tiny hop, a brighter view 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: fixing module association when accepting intake work items, with a ticket reference.
Description check	✅ Passed	The description includes all required sections: detailed explanation of the bug, type of change checkboxes marked, and comprehensive test scenarios.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/intake-module-association-on-accept

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR fixes intake acceptance updates so selected modules (and cycles) are properly associated with the accepted work item, and refactors the update flow by extracting cycle/module association logic into dedicated helpers.

Changes:

• Refactors cycle/module update side-effects into handleCycleChange and handleModuleChange.
• Fixes module association for intake acceptance by removing the previous data.module_ids && payload.module_ids guard.
• Runs cycle/module/property updates in parallel via Promise.all after the main issue update.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/web/core/components/issues/issue-modal/base.tsx`:
- Around line 323-336: The two follow-up mutations handleCycleChange and
handleModuleChange must run serially to avoid optimistic cache races; replace
the Promise.all call so you first await handleCycleChange(data, payload), then
await handleModuleChange(data, payload), and only after both complete call/await
handleCreateUpdatePropertyValues({ issueId: data.id, issueTypeId:
payload.type_id, projectId: payload.project_id, workspaceSlug:
workspaceSlug?.toString(), isDraft }); ensure you update the code around the
Promise.all to these sequential awaits so the optimistic writes from
handleCycleChange and handleModuleChange do not conflict.
- Around line 273-274: The two API calls issues.removeIssueFromCycle(...) and
fetchCycleDetails(...) (and the similar call around the other occurrence) pass
workspaceSlug as a possibly string|string[] from useParams(); coerce
workspaceSlug to a string before calling these helpers (e.g. use
workspaceSlug.toString() or String(workspaceSlug)) so the functions that expect
a string receive a definite string and satisfy TypeScript strict types; update
both call sites (removeIssueFromCycle and fetchCycleDetails and the similar call
around the later occurrence) to pass the coerced string value.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 53f0536d-d724-4906-9065-648e515dffbe

📥 Commits

Reviewing files that changed from the base of the PR and between febf98e and 373b67a.

📒 Files selected for processing (1)

• apps/web/core/components/issues/issue-modal/base.tsx

[coderabbitai]

🧹 Nitpick comments (1)

apps/web/core/components/issues/issue-modal/base.tsx (1)

305-311: Consider renaming loop variable to avoid shadowing moduleId from useParams().

The loop variable moduleId shadows the outer moduleId destructured from useParams() at line 71. While this doesn't cause a bug (the outer variable isn't used inside this function), using a distinct name improves readability.

♻️ Suggested rename

-    for (const moduleId of updatedModuleIds) {
-      if (data.module_ids?.includes(moduleId)) {
-        modulesToRemove.push(moduleId);
+    for (const modId of updatedModuleIds) {
+      if (data.module_ids?.includes(modId)) {
+        modulesToRemove.push(modId);
       } else {
-        modulesToAdd.push(moduleId);
+        modulesToAdd.push(modId);
       }
     }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/web/core/components/issues/issue-modal/base.tsx` around lines 305 - 311,
The for-loop in the updatedModuleIds iteration shadows the outer moduleId from
useParams(); rename the inner loop variable in the loop over updatedModuleIds
(currently "moduleId") to a distinct name such as "updatedModuleId" or "modId"
and update its references inside the loop (the checks against data.module_ids
and pushes to modulesToRemove/modulesToAdd) so that the outer moduleId remains
unshadowed and readability is improved.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@apps/web/core/components/issues/issue-modal/base.tsx`:
- Around line 305-311: The for-loop in the updatedModuleIds iteration shadows
the outer moduleId from useParams(); rename the inner loop variable in the loop
over updatedModuleIds (currently "moduleId") to a distinct name such as
"updatedModuleId" or "modId" and update its references inside the loop (the
checks against data.module_ids and pushes to modulesToRemove/modulesToAdd) so
that the outer moduleId remains unshadowed and readability is improved.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8575b095-9c5e-48ce-9e29-ac9d03c74e57

📥 Commits

Reviewing files that changed from the base of the PR and between 373b67a and 42a0980.

📒 Files selected for processing (1)

• apps/web/core/components/issues/issue-modal/base.tsx