fix: allow special characters in project name#9341
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughRemoves forbidden-character validation for project ChangesProject name validation removal
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@dheeru0198 @pablohashescobar Whenever you have time. Could you please review it? Thank You! |
Resolves #9226 and #9280.
Description
The project name (title) is a user-facing label and should be allowed to contain special characters such as hyphens -, ampersands &, etc. However, the serializers in the backend API and App endpoints were validating the project
ame against Project.FORBIDDEN_IDENTIFIER_CHARS_PATTERN (which is meant only for project identifiers to ensure they are valid prefix patterns). This caused project creation and update requests containing special characters in their name to fail with PROJECT_NAME_CANNOT_CONTAIN_SPECIAL_CHARACTERS.
This change removes the validation of project names against the forbidden identifier characters regex, while keeping the validation in place for project identifiers.
Changes
Summary by CodeRabbit